Add External sources popover instead of the Meta search form

[obulat]

trafficstars

Fixes

Fixes #1197 by @panchovm

Description

This PR implements the 2 changes from the linked issue:

• Moves the external sources buttons to a popup
• Renames the section of the ContentSwitcher from Additional Sources to Coming Soon

Testing Instructions

Run the app and check the meta search section in the bottom of an image or an audio search page. It should have a popup button with links to external sources of openly-licensed media.

Checklist

• [x] My pull request has a descriptive title (not a vague title like Update index.md).
• [x] My pull request targets the default branch of the repository (main) or a parent feature branch.
• [x] My commit messages follow best practices.
• [x] My code follows the established code style of the repository.
• [ ] I added or updated tests for the changes I made (if applicable).
• [ ] I added or updated documentation (if applicable).
• [x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[github-actions[bot]]

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/_preview/1665 Tailwind: https://wordpress.github.io/openverse-frontend/_preview/1665/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

[github-actions[bot]]

Size Change: +2.09 kB (0%)

Total Size: 770 kB

Filename	Size	Change
./.nuxt/dist/client/235.js	0 B	-273 B (removed)	🏆
./.nuxt/dist/client/235.modern.js	0 B	-277 B (removed)	🏆
./.nuxt/dist/client/236.js	0 B	-1.85 kB (removed)	🏆
./.nuxt/dist/client/app.js	109 kB	-672 B (-1%)
./.nuxt/dist/client/app.modern.js	102 kB	-648 B (-1%)
./.nuxt/dist/client/commons/app.js	87.8 kB	-11 B (0%)
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/09090664.js	9.24 kB	-158 B (-2%)
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/09090664.modern.js	9.22 kB	-157 B (-2%)
./.nuxt/dist/client/components/v-meta-search-form.js	3.11 kB	+408 B (+15%)	⚠️
./.nuxt/dist/client/components/v-meta-search-form.modern.js	3.08 kB	+416 B (+16%)	⚠️
./.nuxt/dist/client/components/v-meta-source-list.js	2.58 kB	+527 B (+26%)	🚨
./.nuxt/dist/client/components/v-meta-source-list.modern.js	2.56 kB	+538 B (+27%)	🚨
./.nuxt/dist/client/components/v-no-results.js	2.77 kB	+506 B (+22%)	🚨
./.nuxt/dist/client/components/v-no-results.modern.js	2.74 kB	+517 B (+23%)	🚨
./.nuxt/dist/client/components/v-search-grid.js	5.46 kB	+399 B (+8%)	🔍
./.nuxt/dist/client/components/v-search-grid.modern.js	5.41 kB	+415 B (+8%)	🔍
./.nuxt/dist/client/components/v-sources-table.js	14.4 kB	+46 B (0%)
./.nuxt/dist/client/components/v-sources-table.modern.js	14.4 kB	+47 B (0%)
./.nuxt/dist/client/runtime.js	2.67 kB	-34 B (-1%)
./.nuxt/dist/client/runtime.modern.js	2.68 kB	-34 B (-1%)
./.nuxt/dist/client/228.js	273 B	+273 B (new file)	🆕
./.nuxt/dist/client/228.modern.js	277 B	+277 B (new file)	🆕
./.nuxt/dist/client/229.js	1.85 kB	+1.85 kB (new file)	🆕

ℹ️ View Unchanged

Filename	Size	Change
./.nuxt/dist/client/commons/app.modern.js	76.7 kB	-6 B (0%)
./.nuxt/dist/client/components/loading-icon.js	746 B	0 B
./.nuxt/dist/client/components/loading-icon.modern.js	751 B	0 B
./.nuxt/dist/client/components/table-sort-icon.js	508 B	0 B
./.nuxt/dist/client/components/table-sort-icon.modern.js	512 B	0 B
./.nuxt/dist/client/components/v-all-results-grid.js	4.13 kB	0 B
./.nuxt/dist/client/components/v-all-results-grid.modern.js	4.01 kB	-2 B (0%)
./.nuxt/dist/client/components/v-audio-cell.js	344 B	0 B
./.nuxt/dist/client/components/v-audio-cell.modern.js	349 B	0 B
./.nuxt/dist/client/components/v-audio-details.js	1.66 kB	0 B
./.nuxt/dist/client/components/v-audio-details.modern.js	1.65 kB	0 B
./.nuxt/dist/client/components/v-audio-track-skeleton.js	1.01 kB	0 B
./.nuxt/dist/client/components/v-audio-track-skeleton.modern.js	1.02 kB	0 B
./.nuxt/dist/client/components/v-audio-track.js	4.56 kB	+2 B (0%)
./.nuxt/dist/client/components/v-audio-track.modern.js	4.51 kB	0 B
./.nuxt/dist/client/components/v-back-to-search-results-link.js	570 B	0 B
./.nuxt/dist/client/components/v-back-to-search-results-link.modern.js	575 B	0 B
./.nuxt/dist/client/components/v-bone.js	685 B	0 B
./.nuxt/dist/client/components/v-bone.modern.js	690 B	0 B
./.nuxt/dist/client/components/v-box-layout.js	1.19 kB	0 B
./.nuxt/dist/client/components/v-box-layout.modern.js	1.19 kB	0 B
./.nuxt/dist/client/components/v-content-link.js	1.06 kB	0 B
./.nuxt/dist/client/components/v-content-link.modern.js	1.04 kB	+1 B (0%)
./.nuxt/dist/client/components/v-content-page.js	467 B	0 B
./.nuxt/dist/client/components/v-content-page.modern.js	471 B	0 B
./.nuxt/dist/client/components/v-content-report-button.js	763 B	0 B
./.nuxt/dist/client/components/v-content-report-button.modern.js	773 B	0 B
./.nuxt/dist/client/components/v-content-report-form.js	3.78 kB	0 B
./.nuxt/dist/client/components/v-content-report-form.modern.js	3.59 kB	0 B
./.nuxt/dist/client/components/v-content-report-popover.js	4.45 kB	-3 B (0%)
./.nuxt/dist/client/components/v-content-report-popover.modern.js	4.26 kB	+2 B (0%)
./.nuxt/dist/client/components/v-copy-button.js	3.97 kB	0 B
./.nuxt/dist/client/components/v-copy-button.modern.js	3.98 kB	0 B
./.nuxt/dist/client/components/v-copy-license.js	2.94 kB	+1 B (0%)
./.nuxt/dist/client/components/v-copy-license.modern.js	2.91 kB	0 B
./.nuxt/dist/client/components/v-dmca-notice.js	743 B	0 B
./.nuxt/dist/client/components/v-dmca-notice.modern.js	753 B	0 B
./.nuxt/dist/client/components/v-error-image.js	1.69 kB	0 B
./.nuxt/dist/client/components/v-error-image.modern.js	1.68 kB	0 B
./.nuxt/dist/client/components/v-error-section.js	372 B	0 B
./.nuxt/dist/client/components/v-error-section.modern.js	375 B	0 B
./.nuxt/dist/client/components/v-full-layout.js	1.55 kB	+1 B (0%)
./.nuxt/dist/client/components/v-full-layout.modern.js	1.55 kB	+1 B (0%)
./.nuxt/dist/client/components/v-grid-skeleton.js	1.61 kB	0 B
./.nuxt/dist/client/components/v-grid-skeleton.modern.js	1.62 kB	0 B
./.nuxt/dist/client/components/v-image-cell-square.js	1.01 kB	0 B
./.nuxt/dist/client/components/v-image-cell-square.modern.js	1.02 kB	0 B
./.nuxt/dist/client/components/v-image-cell.js	1.43 kB	0 B
./.nuxt/dist/client/components/v-image-cell.modern.js	1.42 kB	0 B
./.nuxt/dist/client/components/v-image-details.js	1.44 kB	0 B
./.nuxt/dist/client/components/v-image-details.modern.js	1.43 kB	0 B
./.nuxt/dist/client/components/v-image-grid.js	2.57 kB	0 B
./.nuxt/dist/client/components/v-image-grid.modern.js	2.46 kB	0 B
./.nuxt/dist/client/components/v-license-tab-panel.js	923 B	0 B
./.nuxt/dist/client/components/v-license-tab-panel.modern.js	918 B	0 B
./.nuxt/dist/client/components/v-load-more.js	815 B	0 B
./.nuxt/dist/client/components/v-load-more.modern.js	714 B	0 B
./.nuxt/dist/client/components/v-media-license.js	801 B	0 B
./.nuxt/dist/client/components/v-media-license.modern.js	809 B	0 B
./.nuxt/dist/client/components/v-media-reuse.js	1.03 kB	0 B
./.nuxt/dist/client/components/v-media-reuse.modern.js	1.03 kB	0 B
./.nuxt/dist/client/components/v-media-reuse/pages/image/_id.js	2.94 kB	+1 B (0%)
./.nuxt/dist/client/components/v-media-reuse/pages/image/_id.modern.js	2.91 kB	+1 B (0%)
./.nuxt/dist/client/components/v-media-tag.js	429 B	0 B
./.nuxt/dist/client/components/v-media-tag.modern.js	433 B	0 B
./.nuxt/dist/client/components/v-modal.js	875 B	0 B
./.nuxt/dist/client/components/v-modal.modern.js	877 B	+1 B (0%)
./.nuxt/dist/client/components/v-radio.js	1.51 kB	0 B
./.nuxt/dist/client/components/v-radio.modern.js	1.47 kB	0 B
./.nuxt/dist/client/components/v-related-audio.js	1.23 kB	0 B
./.nuxt/dist/client/components/v-related-audio.modern.js	1.24 kB	0 B
./.nuxt/dist/client/components/v-related-images.js	3.14 kB	0 B
./.nuxt/dist/client/components/v-related-images.modern.js	3.02 kB	0 B
./.nuxt/dist/client/components/v-report-desc-form.js	965 B	0 B
./.nuxt/dist/client/components/v-report-desc-form.modern.js	964 B	0 B
./.nuxt/dist/client/components/v-row-layout.js	1.72 kB	0 B
./.nuxt/dist/client/components/v-row-layout.modern.js	1.73 kB	0 B
./.nuxt/dist/client/components/v-scroll-button.js	804 B	0 B
./.nuxt/dist/client/components/v-scroll-button.modern.js	809 B	0 B
./.nuxt/dist/client/components/v-search-results-title.js	673 B	0 B
./.nuxt/dist/client/components/v-search-results-title.modern.js	666 B	0 B
./.nuxt/dist/client/components/v-search-type-radio.js	831 B	0 B
./.nuxt/dist/client/components/v-search-type-radio.modern.js	819 B	-1 B (0%)
./.nuxt/dist/client/components/v-server-timeout.js	298 B	0 B
./.nuxt/dist/client/components/v-server-timeout.modern.js	303 B	0 B
./.nuxt/dist/client/components/v-sketch-fab-viewer.js	991 B	0 B
./.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js	892 B	0 B
./.nuxt/dist/client/components/v-skip-to-content-container.js	888 B	0 B
./.nuxt/dist/client/components/v-skip-to-content-container.modern.js	891 B	0 B
./.nuxt/dist/client/components/v-snackbar.js	977 B	0 B
./.nuxt/dist/client/components/v-snackbar.modern.js	982 B	-1 B (0%)
./.nuxt/dist/client/components/v-tab-panel.js	689 B	0 B
./.nuxt/dist/client/components/v-tab-panel.modern.js	683 B	0 B
./.nuxt/dist/client/components/v-tab.js	1.73 kB	0 B
./.nuxt/dist/client/components/v-tab.modern.js	1.71 kB	0 B
./.nuxt/dist/client/components/v-tabs.js	779 B	0 B
./.nuxt/dist/client/components/v-tabs.modern.js	766 B	0 B
./.nuxt/dist/client/components/v-warning-suppressor.js	298 B	0 B
./.nuxt/dist/client/components/v-warning-suppressor.modern.js	302 B	0 B
./.nuxt/dist/client/pages/about.js	1.05 kB	-1 B (0%)
./.nuxt/dist/client/pages/about.modern.js	1.06 kB	-1 B (0%)
./.nuxt/dist/client/pages/audio/_id.js	6.42 kB	-3 B (0%)
./.nuxt/dist/client/pages/audio/_id.modern.js	6.26 kB	0 B
./.nuxt/dist/client/pages/feedback.js	3.23 kB	+1 B (0%)
./.nuxt/dist/client/pages/feedback.modern.js	3.2 kB	0 B
./.nuxt/dist/client/pages/image/_id.js	7.05 kB	+1 B (0%)
./.nuxt/dist/client/pages/image/_id.modern.js	6.82 kB	-1 B (0%)
./.nuxt/dist/client/pages/index.js	5.09 kB	-1 B (0%)
./.nuxt/dist/client/pages/index.modern.js	4.97 kB	-1 B (0%)
./.nuxt/dist/client/pages/meta-search.js	1.67 kB	0 B
./.nuxt/dist/client/pages/meta-search.modern.js	1.68 kB	+3 B (0%)
./.nuxt/dist/client/pages/preferences.js	1.28 kB	0 B
./.nuxt/dist/client/pages/preferences.modern.js	1.27 kB	0 B
./.nuxt/dist/client/pages/search-help.js	1.55 kB	0 B
./.nuxt/dist/client/pages/search-help.modern.js	1.55 kB	0 B
./.nuxt/dist/client/pages/search.js	2.72 kB	0 B
./.nuxt/dist/client/pages/search.modern.js	2.56 kB	0 B
./.nuxt/dist/client/pages/search/audio.js	2.86 kB	-1 B (0%)
./.nuxt/dist/client/pages/search/audio.modern.js	2.75 kB	0 B
./.nuxt/dist/client/pages/search/image.js	2.96 kB	0 B
./.nuxt/dist/client/pages/search/image.modern.js	2.83 kB	0 B
./.nuxt/dist/client/pages/search/index.js	815 B	0 B
./.nuxt/dist/client/pages/search/index.modern.js	731 B	-1 B (0%)
./.nuxt/dist/client/pages/search/model-3d.js	242 B	0 B
./.nuxt/dist/client/pages/search/model-3d.modern.js	246 B	0 B
./.nuxt/dist/client/pages/search/search-page.types.js	266 B	0 B
./.nuxt/dist/client/pages/search/search-page.types.modern.js	271 B	0 B
./.nuxt/dist/client/pages/search/video.js	239 B	0 B
./.nuxt/dist/client/pages/search/video.modern.js	243 B	-1 B (0%)
./.nuxt/dist/client/pages/sources.js	1.44 kB	0 B
./.nuxt/dist/client/pages/sources.modern.js	1.45 kB	0 B
./.nuxt/dist/client/vendors/app.js	47.8 kB	-5 B (0%)
./.nuxt/dist/client/vendors/app.modern.js	47.1 kB	-3 B (0%)

_{compressed-size-action}

[krysal]

Was #1205 too far behind to recover some of the changes from there?

[obulat]

Was #1205 too far behind to recover some of the changes from there?

It was renaming the 'meta-search' term inside the code, and this PR should probably use some of the changes from there. Here, most of the changes are related to moving the Additional/External sources buttons to a popup.

[krysal]

If it is too cumbersome now, we can leave it as it is, but it would have been good to resolve that PR (update it or close it) before opening another related one.

Tagging @panchovm as he probably wants to check this!

[fcoveram]

Thanks for tagging me @krysal

I noticed two things:

Popover padding

The popover has a 12px padding instead of 8px as the mockup. Below a screenshot of what I see.

Popover description padding

The title and description area, both above the links list, have a 12px for left and right padding instead of 16px.

Related questions On the other hand, I have two doubts.

• I do not see the "coming soon" section in the content switcher popover. Do we need to wait for making the 3D model support visible?
• This PR shows a change in the links section. Are we tackling the text changes in a different PR? I am referring to Not finding what you're looking for? Try additional image sources and Click on a source below to directly search other collections of CC-licensed images texts.

Despite the above, the popover looks great ✨

[obulat]

I've tried to update the paddings, @panchovm. Does it look good?

~~I will also edit the text after #1647 is merged.~~

This is the latest version, after #1647 was merged and more changes to the text added:

I do not see the "coming soon" section in the content switcher popover. Do we need to wait to make the 3D model support visible?

This section is currently under a flag that is turned off in production, but here's what it looks like:

[openverse-bot]

Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR:

@zackkrida @krysal @dhruvkb This reminder is being automatically generated due to the urgency configuration.

Excluding weekend[^1] days, this PR was updated 4 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)[^2].

@obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

[^1]: Specifically, Saturday and Sunday. [^2]: For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range.

[zackkrida]

@obulat looks like some new test failures here.