openverse-frontend icon indicating copy to clipboard operation
openverse-frontend copied to clipboard

Switch to or add `pre-commit` to allow for syncing lint configuration across repositories.

Open sarayourfriend opened this issue 3 years ago • 0 comments

Problem

We currently use husky for the pre-commit hook in the frontend repository. If we switched to (or added) pre-commit, it would allow us to sync all linting rules that are relevant to multiple repositories across all repos. It would also allow easily adding JavaScript or Python to a repo that doesn't have it yet without having to also fiddle with this devex stuff to get linting working.

Description

Adding pre-commit is probably the easiest option and allows the most flexibility for this repository. We'd want to add it as part of the husky configuration and require it as part of the repository dev configuration. If we do this, then please open an issue in the WordPress/openverse repository to start syncing the pre-commit-config.yaml across all our repositories.

Implementation

  • [ ] 🙋 I would be interested in implementing this feature.

sarayourfriend avatar Aug 11 '22 12:08 sarayourfriend