openverse-frontend icon indicating copy to clipboard operation
openverse-frontend copied to clipboard

Trailing edge of header buttons does not align with search results

Open sarayourfriend opened this issue 3 years ago • 6 comments

Description

The trailing edge of the header buttons is not aligned with the trailing edge of the search results. The leading edge is aligned. image

Reproduction

  1. Go to `/search/?q=birds` on a wide viewport and see the screenshot

Resolution

  • [ ] 🙋 I would be interested in resolving this bug.

sarayourfriend avatar May 06 '22 15:05 sarayourfriend

the header is aligned when sticky, which makes this extra tricky:

CleanShot 2022-05-06 at 11 52 06@2x

zackkrida avatar May 06 '22 15:05 zackkrida

I guess the difference is the Openverse logo doesn't have a border when you're not scrolled :thinking:

sarayourfriend avatar May 06 '22 21:05 sarayourfriend

🙋 I would be interested in resolving this bug.

carlosreyesmunoz avatar Jun 09 '22 05:06 carlosreyesmunoz

Thanks, @carlosreyesmunoz! I think this issue actually needs input from a designer before we can work on it (indeed if it even needs to be worked on). If you'd like to help with that I'll ping @panchovm. I'm not sure how we would want to resolve this given what @zackkrida pointed out about how when the header is scrolled, the button borders go away and then it is aligned.

I know @panchovm is working on some header refinements so this issue might be irrelevant in the face of those changes.

sarayourfriend avatar Jun 09 '22 17:06 sarayourfriend

Alright @sarayourfriend, no worries, better to wait and see, thank you!😀

carlosreyesmunoz avatar Jun 10 '22 06:06 carlosreyesmunoz

Thanks @carlosreyesmunoz for showing interest in this.

In #1488 I shared a proposal for improving the image results grid. The design idea tackles this problem so looking forward to setting a priority level.

fcoveram avatar Jun 16 '22 18:06 fcoveram