swayfx icon indicating copy to clipboard operation
swayfx copied to clipboard

Titlebar corner radius does not match bottom corners

Open ErikReider opened this issue 2 years ago • 9 comments

This only occurs when the border size becomes large enough to be noticeable. Fixing this will make it a lot easier to fix #64 current issue when using these layouts

Example: image

ErikReider avatar Jan 01 '23 18:01 ErikReider

Does the issue exist with titlebars in general or just these layouts? If just the layouts I suspect I can fix it rn

WillPower3309 avatar Jan 01 '23 19:01 WillPower3309

With titlebars

ErikReider avatar Jan 01 '23 19:01 ErikReider

This is actually a pretty complex issue that revolves around a lot of the sway logic assuming that the titlebar height / padding should be constant for all windows. Since we can have per container border thickness, which impacts the per container corner radius, there's going to have to be some refactoring here. I've started looking into it, but there's a lot of things to consider here

WillPower3309 avatar Jan 01 '23 23:01 WillPower3309

No rush. It's not a gigantic issue. We can always make the shadow mask conform to how it is now and fix it when this is fixed :)

ErikReider avatar Jan 02 '23 17:01 ErikReider

How are things going with this? Currently having the same issue, attached some screenshots if it might help.

  1. the top (titlebar) corners are different thickness
  2. the titlebars have corners regardless of layout, like tabbed layout. This one is weird because the parent tabs are behaving, as seen in this preview, but the tabs below do not. I would assume that the tabs might only misbehave on the left most and right most inner tabs, but even the tabs in between have corners

image

cheers!

yadobler avatar Oct 02 '23 08:10 yadobler

How are things going with this? Currently having the same issue, attached some screenshots if it might help.

  1. the top (titlebar) corners are different thickness
  2. the titlebars have corners regardless of layout, like tabbed layout. This one is weird because the parent tabs are behaving, as seen in this preview, but the tabs below do not. I would assume that the tabs might only misbehave on the left most and right most inner tabs, but even the tabs in between have corners

image

cheers!

this only happens if scaling is not a multiple of 50% try shifting to the nearest multiple of 50% till it gets fixed

adityavishwakarma69 avatar Mar 27 '24 14:03 adityavishwakarma69

How are things going with this? Currently having the same issue, attached some screenshots if it might help.

  1. the top (titlebar) corners are different thickness
  2. the titlebars have corners regardless of layout, like tabbed layout. This one is weird because the parent tabs are behaving, as seen in this preview, but the tabs below do not. I would assume that the tabs might only misbehave on the left most and right most inner tabs, but even the tabs in between have corners

image

cheers!

What scale do you have in your config?

WillPower3309 avatar Mar 27 '24 15:03 WillPower3309

@WillPower3309 @adityavishwakarma69 oh apologies for the late reply. I've moved to hyprland, so unfortunately I don't know.

I have dug through my old dot files, and I have this:

    output * {
        bg $wallpaper fill
        scale 2
    } 

So I'm guessing it's 200% maybe?

But I'll have to reinstall and tinker with it.

yadobler avatar May 27 '24 23:05 yadobler

@WillPower3309 @adityavishwakarma69 oh apologies for the late reply. I've moved to hyprland, so unfortunately I don't know.

I have dug through my old dot files, and I have this:

    output * {
        bg $wallpaper fill
        scale 2
    } 

So I'm guessing it's 200% maybe?

But I'll have to reinstall and tinker with it.

Thanks for the info! I'll try to reproduce it

WillPower3309 avatar May 28 '24 01:05 WillPower3309