Wilfred Hughes

Results 324 issues of Wilfred Hughes

Equality isn't well defined: sometimes we want content equality, other times we want reference equality. It's easy to screw up.

``` test: foo: 'a' ``` ``` test: foo: 'b' fail: true ``` Spotted in #266. The YAML parse tree does not include `fail: true`.

Compare v5.16..v5.17 -- shows a bunch of syntax errors too.

See src/parser.c in 06dfec714e2424be9d19aacb739771746f5aec2b (introduced in vendored dir in a7e298dfa19fb75b55958233f6d0d759da646ed9). Looks like the rust parser.

Now that we're splitting trees into regions before diffing, this could be parallel if change state wasn't in the tree.

See e.g. 3ba0a6808a9da313de67ec8a23456fcb2ed0fbb5 ![Screenshot from 2022-04-16 20-09-48](https://user-images.githubusercontent.com/70800/163698550-44571478-39a1-4515-8005-92b8b243c074.png)

See e.g. 14b52e6ac04fcc77c3a8123cbbf3dc78451adff3 in hhvm, in `naming.ml`.

This would be interesting for e.g. Rust assertion failures.