ImHex icon indicating copy to clipboard operation
ImHex copied to clipboard

[Feature/Bug] File modification indicator seems to be mostly broken

Open sdasda7777 opened this issue 3 years ago • 6 comments

What feature would you like to see?

Firstly, it seems to me when having multiple files open, you can see that some of the files were changed, but not which one(s). That doesn't seem that helpful, having the indicator for each file would be great (also displaying it in the box where you switch between open files would be nice). Also if you change a file, and then open another one, and the indicator is gets stuck stuck (doesn't go away when you save).

How will this feature be useful to you and others?

This seems like a fairly basic feature of any editor to me.

Request Type

  • [ ] I can provide a PoC for this feature or am willing to work on it myself and submit a PR

sdasda7777 avatar Apr 22 '22 14:04 sdasda7777

This issue is marked stale as it has been open for 11 months without activity. Please try the latest ImHex version. (Avaiable here: https://imhex.download/ for release and https://imhex.download/#nightly for development version) If the issue persists on the latest version, please make a comment on this issue again

Without response, this issue will be closed in one month.

github-actions[bot] avatar Aug 03 '24 16:08 github-actions[bot]

This also seems to have been improved, but saving the file doesn't seem to clear the modification indicator.

sdasda7777 avatar Aug 04 '24 14:08 sdasda7777

That indicator is not only for the input file. Modifying the pattern also will turn the indicator on. saving either the input file or the pattern or both will not clear the indicator. For that you need to save the project which will clear all the indicators on the providers that are on.

paxcut avatar Aug 04 '24 14:08 paxcut

I'm sorry, but the current behaviour really doesn't make sense to me. I get the indicator being on when DATA_MODIFIED || PATTERN_MODIFIED, that makes sense, but when I just open file, modify few bytes, save it, and want to close it, this is just really confusing. I can't see why it wouldn't be possible to clear the modification indicator on saving, since there weren't any patterns modifications.

sdasda7777 avatar Aug 04 '24 15:08 sdasda7777

I apologize for not being clear on the intention of my post.I agree with you 100% and was merely explaining how the nonsensical behavior came to be. Not many people use Imhex to modify files but it should certainly accommodate whoever wants to.

paxcut avatar Aug 04 '24 16:08 paxcut

This issue is marked stale as it has been open for 11 months without activity. Please try the latest ImHex version. (Avaiable here: https://imhex.download/ for release and https://imhex.download/#nightly for development version) If the issue persists on the latest version, please make a comment on this issue again

Without response, this issue will be closed in one month.

github-actions[bot] avatar Jul 13 '25 02:07 github-actions[bot]