Andrea Giammarchi
Andrea Giammarchi
@JeffersGlass it looks like there are too many unrelated files in here ... are you tackling the rebase or do you need any help with that?
@JeffersGlass few comments / nits you can freely ignore if you think my opinion is not so relevant, otherwise this LGTM and thanks for working on it, it looks awesome!
Hello folks 👋 With the landing of https://github.com/pyscript/pyscript/pull/1403 this discussion looks like a piece of cake to me ... beside the *MutationObserver* story which is something easier to implement now,...
> Just to be sure, does that mean the whole work with the @when decorator as well? Or just handling -code cases? > > This is just an opinion, but...
I hope we deployed in the meantime 😅
No follow up in here, closing as Pyodide is way beyond 0.22.1 or 0.23
OK, this works now (on my machine™️) ... removed the WIP flag, let's see if tests are happy too.
@FabioRosado thank you for hints and review. While updating the docs I've realized that `output` and `stderr` attributes were not copied over the live `pyScriptTag` (fixed) + I've just updated...
> Oh it seems the tests for the banner may have broken thinking I haven't changed the logic an inch from last time CI was green ... this is a...
@FabioRosado actually ... I did break everything when removing `getPySrc` ... I guess it was needed after all, we can refactor that later.