WebKit icon indicating copy to clipboard operation
WebKit copied to clipboard

Published 20 hours ago • verified publisher icon WebKit

Fixed backgrounds should behave like 'scroll' inside transformed elements

Open vitorroriz opened this issue 3 years ago • 5 comments

d4322edcec39c91e1223b3a6cdecb034f69b6441

Fixed backgrounds should behave like 'scroll' inside transformed elements
https://bugs.webkit.org/show_bug.cgi?id=15679
Include a Radar link (OOPS!).

Reviewed by NOBODY (OOPS!).

* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry const):

According to spec (https://drafts.csswg.org/css-transforms/), if an element or any of its ancestor elements
have a transform, its background-attachment property should be treated as it has 'scroll' value instead of 'fixed'.

https://github.com/WebKit/WebKit/commit/d4322edcec39c91e1223b3a6cdecb034f69b6441

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
  ~~🛠 🧪 merge~~ ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

vitorroriz avatar Aug 17 '22 23:08 vitorroriz

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/32da8497bd4f9f65e423b52808e992fe2096a948)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ ~~🛠 ios~~ ⏳ 🛠 mac ⏳ 🛠 wpe ✅ ~~🛠 🧪 win~~
✅ 🧪 bindings ✅ ~~🛠 ios-sim~~ ⏳ 🛠 mac-debug ⏳ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl ✅ ~~🧪 ios-wk2~~ ⏳ 🛠 mac-AS-debug ⏳ 🧪 gtk-wk2
✅ ~~🧪 api-ios~~ ⏳ 🧪 api-mac ⏳ 🧪 api-gtk
⏳ 🛠 tv ⏳ 🧪 mac-wk1
⏳ 🛠 tv-sim ⏳ 🧪 mac-wk2
⏳ 🛠 watch ⏳ 🧪 mac-AS-debug-wk2
❌ 🛠 watch-sim ⏳ 🧪 mac-wk2-stress

webkit-early-warning-system avatar Aug 17 '22 23:08 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/c028a7acad95cf391cfd9153623b98eaa257ff68)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ⏳ 🛠 mac-AS-debug ❌ 🧪 gtk-wk2
✅ ~~🧪 api-ios~~ ✅ ~~🧪 api-mac~~ ❌ 🧪 api-gtk
✅ 🛠 tv ✅ ~~🧪 mac-wk1~~
✅ 🛠 tv-sim ❌ 🧪 mac-wk2
✅ 🛠 watch ⏳ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

webkit-early-warning-system avatar Aug 17 '22 23:08 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/ad64f92c501b211596a2a4044bdc0b399ad48cba)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl loading 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-wk1
✅ 🛠 tv-sim ❌ 🧪 mac-wk2
✅ 🛠 watch ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

webkit-early-warning-system avatar Aug 18 '22 13:08 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/be9a59c28ef323dbadda5983525695951b0bab6e)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ❌ 🧪 mac-wk2
✅ 🛠 watch ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

webkit-early-warning-system avatar Aug 22 '22 15:08 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/d4322edcec39c91e1223b3a6cdecb034f69b6441)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
  ~~🛠 🧪 merge~~ ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

webkit-early-warning-system avatar Sep 05 '22 15:09 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/878bb46ab7000fe538d1dc427a4440e67921172c)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

webkit-early-warning-system avatar Sep 27 '22 15:09 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/aac96550e05096dec9bba6297aa651e1b433aea0)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ❌ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

webkit-early-warning-system avatar Sep 28 '22 12:09 webkit-early-warning-system

EWS run on current version of this PR (hash https://github.com/WebKit/WebKit/commit/e9fe5826b2994cbe37bffbfc6fbb82eb3ab097ac)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios   ~~🧪 api-mac~~ ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch   ~~🧪 mac-AS-debug-wk2~~
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

webkit-early-warning-system avatar Sep 30 '22 12:09 webkit-early-warning-system

Committed 255055@main (eba490ba3cc4): https://commits.webkit.org/255055@main

Reviewed commits have been landed. Closing PR #3433 and removing active labels.

webkit-commit-queue avatar Oct 01 '22 00:10 webkit-commit-queue