wabt icon indicating copy to clipboard operation
wabt copied to clipboard

Inconsistent archive name for macos

Open anuraaga opened this issue 2 years ago • 3 comments

I noticed that the macos archive name in the release is inconsistent vs ubuntu/windows. It has the version name, -12 while the others don't. This is because the name is computed by stripping out the GHA runner name of -latest, but for macos the runner is not -latest

https://github.com/WebAssembly/wabt/blob/main/.github/actions/release-archive/action.yml#L16 https://github.com/WebAssembly/wabt/blob/main/.github/workflows/build.yml#L33

Presumably these are all supposed to be symmetric. One option to fix would be to switch to using lowercase of runner.os instead of matrix.os, that word contains Linux, MacOS, Windows. Note that it is linux instead of ubuntu, this would be a relatively significant change to the current name but perhaps it's a more appropriate one?

anuraaga avatar Jun 12 '23 05:06 anuraaga

I guess we transitioned from -latest to -12 for macos but didn't realise that would break the release builder. Simplest fix for now would likely be to just strip the -12 suffix in the same place we strip the -latest suffix.

sbc100 avatar Jun 12 '23 14:06 sbc100

is this (still) a problem?

SoniEx2 avatar May 14 '24 22:05 SoniEx2

It looks like things changed a little since filing, now I see a suffix on macos and ubuntu, and none on Windows. Still not consistent, maybe it doesn't matter too much. But I think with macos-14 added, the confusion has increased since many people won't know it's a difference between x86 and arm.

Following common naming like darwin-amd64, etc could make the release archives easier to use.

anuraaga avatar May 15 '24 01:05 anuraaga