wabt icon indicating copy to clipboard operation
wabt copied to clipboard

Support for final wasm-simd128 specin the wabt interpreter?

Open steven-johnson opened this issue 4 years ago • 8 comments

Is there work underway to bring the WABT interpreter in line with the final proposal for the wasm-simd128 spec? If so, is there any rough ETA? If not, is this work scheduled to be done? (Or has it already been done and I somehow missed it?)

Halide currently uses the WABT interpreter for a fair number of our correctness tests (where performance is unimportant), and simd support is pretty crucial for most Halide users.

steven-johnson avatar Mar 01 '21 18:03 steven-johnson

No, I don't know of any work underway for this right now. I can take a crack at it this week, though.

tlively avatar Mar 01 '21 21:03 tlively

Excellent. Let me know if I can assist.

steven-johnson avatar Mar 01 '21 23:03 steven-johnson

If you're interested, PRs would be super welcome! If not, no problem :)

tlively avatar Mar 01 '21 23:03 tlively

If you're interested, PRs would be super welcome!

Not sure where to begin (ie, code structure, testing requirements, etc) & am juggling several things at the moment, but if you can open a PR doing one of the ops (as a useful reference/example) I will try to use that as a basis to help fill in the gaps.

steven-johnson avatar Mar 02 '21 16:03 steven-johnson

@steven-johnson I can work on the opcode updates, don't worry for now, I should get something up today. :) (note this is only for adding the new opcodes, interpreter might take longer.)

ngzhian avatar Mar 03 '21 18:03 ngzhian

Noticed that wasm-strip fails to strip modules with SIMD instructions in it, is this the same issue or should we file a separate issue for that?

repi avatar Jan 06 '22 11:01 repi

Noticed that wasm-strip fails to strip modules with SIMD instructions in it, is this the same issue or should we file a separate issue for that?

what's the error message? it's likely a new issue, the opcodes have already been updated.

ngzhian avatar Jan 06 '22 16:01 ngzhian

filed separate issue:

  • #1803

repi avatar Jan 12 '22 13:01 repi

Done in 1ba6f750a50c9b033a2309f979edeb0b4bcbf1ef

keithw avatar Sep 18 '22 05:09 keithw