memory64 icon indicating copy to clipboard operation
memory64 copied to clipboard

(Bikeshed) Should we rename the parameters for `Table.get` and `Table.set`?

Open bvisness opened this issue 1 year ago • 1 comments

@backes points out in this comment that perhaps we should rename the index parameter on Table.get and Table.set to address as a result of #67. I'm not sure we want to, since the existing spec already uses the term "index" and it's quite clear in context that it's referring to the index of an element. Thoughts? (This certainly does not need to block phase 4 vote imo. Just wanted to discuss it before it all ends up on MDN and wherever else.)

bvisness avatar Oct 22 '24 15:10 bvisness

It's obviously not super critical, but while we change the type from unsigned long to AddressValue I would prefer to also just rename index to address, for consistency.

backes avatar Oct 23 '24 10:10 backes

Closing this issue since this proposal is done and the repo is being archived. Any further discussion can take place in the spec or design repos.

sbc100 avatar Jan 15 '25 17:01 sbc100