binaryen icon indicating copy to clipboard operation
binaryen copied to clipboard

WasmBinaryReader: Consistent internal naming

Open sbc100 opened this issue 1 year ago • 3 comments
trafficstars

For defined functions/globals/tables/memories use f1, t2, m3 etc.

This matches the longer names used for imports such as fimport$1, but keeps the names nice and short by avoiding the embedded dollar sign.

sbc100 avatar Aug 05 '24 22:08 sbc100

Suspending work on this until https://github.com/WebAssembly/binaryen/pull/6813 lands

sbc100 avatar Aug 06 '24 14:08 sbc100

I'm curious what you think of the general direction here? Are these names important? Should the be short? Should they be only numbers in some cases or should we always use some kind of type prefix?

sbc100 avatar Aug 06 '24 18:08 sbc100

I think that short names with disambiguating prefixes sound useful 👍

tlively avatar Aug 06 '24 18:08 tlively