WasmEdge
WasmEdge copied to clipboard
[Component] break down validation for most tasks
This is a style guide and detailed TODO list.
Hello, I am a code review agent on flows.network. Here are my reviews of changed source code files in this PR.
include/ast/component/instance.h
Potential issues
N/A
Summary of changes
N/A
include/validator/validator_component.h
Potential issues
N/A
Summary of changes
N/A
lib/loader/ast/component/component_instance.cpp
Potential issues
N/A
Summary of changes
N/A
lib/validator/CMakeLists.txt
Potential issues
N/A
Summary of changes
N/A
lib/validator/validator.cpp
Potential issues
N/A
Summary of changes
N/A
lib/validator/validator_component.cpp
Potential issues
N/A
Summary of changes
N/A
NOTE: who wants to implement #3150 should base on this structure, and refine out more details.
Codecov Report
Attention: Patch coverage is 36.60714% with 71 lines in your changes missing coverage. Please review.
Project coverage is 80.05%. Comparing base (
f5cb997) to head (1c77525). Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #3619 +/- ##
==========================================
- Coverage 80.17% 80.05% -0.12%
==========================================
Files 275 277 +2
Lines 37840 37944 +104
Branches 6662 6687 +25
==========================================
+ Hits 30339 30377 +38
- Misses 5932 5994 +62
- Partials 1569 1573 +4
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
NOTE: squash
@q82419 Do you also consider a new class ComponentValidator?
riscv
Dockerfile.aarch64.ubuntu18.04:3
--------------------
1 | FROM riscv64/ubuntu
2 | COPY ./run-on-arch-install.sh /root/run-on-arch-install.sh
3 | >>> RUN chmod +x /root/run-on-arch-install.sh && /root/run-on-arch-install.sh
--------------------
ERROR: failed to solve: process "/bin/sh -c chmod +x /root/run-on-arch-install.sh && /root/run-on-arch-install.sh" did not complete successfully: exit code: 100
LOG Ubuntu segment fault.
NOTE: Rebasing introduce missing cases and lead to build failures.