WasmEdge icon indicating copy to clipboard operation
WasmEdge copied to clipboard

[Component] break down validation for most tasks

Open dannypsnl opened this issue 1 year ago • 8 comments

This is a style guide and detailed TODO list.

dannypsnl avatar Aug 02 '24 08:08 dannypsnl

Hello, I am a code review agent on flows.network. Here are my reviews of changed source code files in this PR.


include/ast/component/instance.h

Potential issues

N/A

Summary of changes

N/A

include/validator/validator_component.h

Potential issues

N/A

Summary of changes

N/A

lib/loader/ast/component/component_instance.cpp

Potential issues

N/A

Summary of changes

N/A

lib/validator/CMakeLists.txt

Potential issues

N/A

Summary of changes

N/A

lib/validator/validator.cpp

Potential issues

N/A

Summary of changes

N/A

lib/validator/validator_component.cpp

Potential issues

N/A

Summary of changes

N/A

juntao avatar Aug 02 '24 08:08 juntao

NOTE: who wants to implement #3150 should base on this structure, and refine out more details.

dannypsnl avatar Aug 02 '24 08:08 dannypsnl

Codecov Report

Attention: Patch coverage is 36.60714% with 71 lines in your changes missing coverage. Please review.

Project coverage is 80.05%. Comparing base (f5cb997) to head (1c77525). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
include/validator/validator_component.h 35.57% 63 Missing and 4 partials :warning:
lib/validator/validator_component.cpp 66.66% 1 Missing and 1 partial :warning:
include/ast/component/instance.h 0.00% 1 Missing :warning:
lib/loader/ast/component/component_instance.cpp 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3619      +/-   ##
==========================================
- Coverage   80.17%   80.05%   -0.12%     
==========================================
  Files         275      277       +2     
  Lines       37840    37944     +104     
  Branches     6662     6687      +25     
==========================================
+ Hits        30339    30377      +38     
- Misses       5932     5994      +62     
- Partials     1569     1573       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 02 '24 08:08 codecov[bot]

NOTE: squash

dannypsnl avatar Aug 08 '24 07:08 dannypsnl

@q82419 Do you also consider a new class ComponentValidator?

dannypsnl avatar Aug 13 '24 01:08 dannypsnl

riscv

Dockerfile.aarch64.ubuntu18.04:3
  --------------------
     1 |     FROM riscv64/ubuntu
     2 |     COPY ./run-on-arch-install.sh /root/run-on-arch-install.sh
     3 | >>> RUN chmod +x /root/run-on-arch-install.sh && /root/run-on-arch-install.sh
  --------------------
  ERROR: failed to solve: process "/bin/sh -c chmod +x /root/run-on-arch-install.sh && /root/run-on-arch-install.sh" did not complete successfully: exit code: 100

dannypsnl avatar Aug 22 '24 03:08 dannypsnl

LOG Ubuntu segment fault.

dannypsnl avatar Sep 02 '24 03:09 dannypsnl

NOTE: Rebasing introduce missing cases and lead to build failures.

dannypsnl avatar Oct 15 '24 10:10 dannypsnl