WasmEdge
WasmEdge copied to clipboard
[component model] instantiate
#3151
- [component model] linear indexed space
- instance section
- inline export immediate module instance
- instantiate module instance via module definition
- instantiate component instance via component definition
- canonical section
- lift: wrap a core module function with component types
- lower: wrap a component function with core types
- alias definitions
- import definitions
- export definitions
- type section (record into a index space)
- instance section
- [wasi-http] a test component in wasi-http plugin, the demo helps us to interact with canonical ABI
- [wasi-poll] standard plugin
- [formatter] format component types and
AST::FunctionType
The tests failing are all wrong instance address.
Codecov Report
Attention: Patch coverage is 4.71698% with 909 lines in your changes missing coverage. Please review.
Project coverage is 78.42%. Comparing base (
813c200) to head (e7183a4). Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #3218 +/- ##
==========================================
- Coverage 80.53% 78.42% -2.11%
==========================================
Files 253 262 +9
Lines 34916 35873 +957
Branches 6143 6474 +331
==========================================
+ Hits 28119 28133 +14
- Misses 5367 6308 +941
- Partials 1430 1432 +2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The windows failure is irrelevant with this PR.
The windows failure is irrelevant with this PR.
Ref: #3257
NOTE: cleanup log once demo can totally rely on canonical ABI, which means we at least supports string.
Please fix the Windows build.
I have no idea how would changes fail the Windows tests.
Update 2024/05/15
I check and found the fail is about a test cleanup failed, should not relate to PR changes.
@hydai The bug is fixed, with update branch this should be ready to be merged.
@dannypsnl Please rebase to the latest master.
@hydai rebased.
The Windows CI failed.
Yes, file system missing, do we changes something in CI?
We don't. Except for the missing filesystem, however, the unit tests also failed (SEGFAULT).
That's weird, on our remote Windows tests are passed.
That's weird, on our remote Windows tests are passed.
Let me try to bump deps in the workflow.
That's weird, on our remote Windows tests are passed.
In our experience, this situation usually occurs when we used an undefined behavior.
The Windows CI on the master branch failed. I need to figure out the reason. https://github.com/WasmEdge/WasmEdge/actions/runs/9413379849/job/25930046709?pr=3455
@q82419 I think we can move forward to merge this and fix the windows CI later.
@hydai Rebase are done
The prefixes should be in the same style, such as [WASI] and [Misc]. These commits contain multiple styles of the same name, including [Misc] vs. [misc].
@hydai updated