multiple-cucumber-html-reporter icon indicating copy to clipboard operation
multiple-cucumber-html-reporter copied to clipboard

bug on attachement when updating to cucumberjs 10+

Open lerhum opened this issue 2 years ago • 2 comments

Environment (please complete the following information):

multiple-cucumber-html-reporter: 3.4.0
Node.js version: v18.17.1
NPM version: 9.6.7
Platform name and version: mac os
Cucumber version: 10.0.1

Describe the bug In the JSON formatter output of multiple-cucumber-html-reporter, all attachments, including those initially attached as plain text strings, are now Base64 encoded. This uniform encoding approach leads to ambiguity for consumers of the report, as they cannot distinguish whether an attachment was originally a plain text string or a different file format.

To Reproduce Steps to reproduce the behavior:

just generate a report based on cucumber 10.0.1 with some attachement (json/ text / image)

Expected behavior The expected behavior was that string attachments would remain as plain text in the JSON formatter output, while other types of attachments would be Base64 encoded. This distinction would enable consumers to easily identify the nature of the attachments without additional processing.

Additional context To resolve this issue, a decoding mechanism such as atob(embedding.data); should be implemented to correctly decode Base64 attachments before passing them to the report. This would ensure that plain text attachments maintain their original format in the JSON output.

lerhum avatar Nov 23 '23 15:11 lerhum

Hello, the pull request has not yet been accepted, any feedback to resolve the problem?

charleslana avatar Dec 12 '23 14:12 charleslana

Hi @charleslana , the PR has a failing test. Once it gets fixed, we are good to merge it.

WasiqB avatar Dec 17 '23 15:12 WasiqB