web3modal icon indicating copy to clipboard operation
web3modal copied to clipboard

chore/wallet checkout test

Open KannuSingh opened this issue 8 months ago • 7 comments

Description

Implementing wallet_checkout rpc test

Type of change

  • [ ] Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx For GH issues: closes #...

Showcase (Optional)

Screenshot 2025-03-13 at 1 24 48 AM Screenshot 2025-03-13 at 1 25 22 AM Screenshot 2025-03-13 at 1 24 58 AM Screenshot 2025-03-13 at 1 25 07 AM Screenshot 2025-03-13 at 1 35 19 AM

Checklist

  • [ ] Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • [ ] My changes generate no new warnings
  • [ ] I have reviewed my own code
  • [ ] I have filled out all required sections
  • [ ] I have tested my changes on the preview link
  • [ ] Approver of this PR confirms that the changes are tested on the preview link

KannuSingh avatar Mar 07 '25 09:03 KannuSingh

⚠️ No Changeset found

Latest commit: 51f078dd86687cec475c9f838fb4ac78120b73da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Mar 07 '25 09:03 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 1:11pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 1:11pm
12 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) Mar 17, 2025 1:11pm
appkit-basic-ep-example ⬜️ Ignored (Inspect) Mar 17, 2025 1:11pm
appkit-basic-example ⬜️ Ignored (Inspect) Mar 17, 2025 1:11pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Mar 17, 2025 1:11pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Mar 17, 2025 1:11pm
appkit-ethers5-bera ⬜️ Ignored (Inspect) Mar 17, 2025 1:11pm
appkit-nansen-demo ⬜️ Ignored (Inspect) Mar 17, 2025 1:11pm
appkit-vue-solana ⬜️ Ignored (Inspect) Mar 17, 2025 1:11pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Mar 17, 2025 1:11pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Visit Preview Mar 17, 2025 1:11pm
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Mar 17, 2025 1:11pm
vue-wagmi-example ⬜️ Ignored (Inspect) Mar 17, 2025 1:11pm

vercel[bot] avatar Mar 07 '25 09:03 vercel[bot]

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 74.6% 24325 / 32607
🔵 Statements 74.6% 24325 / 32607
🔵 Functions 65.61% 2046 / 3118
🔵 Branches 81.92% 4500 / 5493
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/src/utils/HelpersUtil.ts 93.85% 100% 77.77% 93.85% 40, 45, 48, 102-105, 134
Generated in workflow #10186 for commit 9b73a30 by the Vitest Coverage Report Action

github-actions[bot] avatar Mar 07 '25 09:03 github-actions[bot]

Do we need this button for every single wagmi file?

lukaisailovic avatar Mar 12 '25 13:03 lukaisailovic

Can we make this a chore not a feat as its not a feature for appkit?

lukaisailovic avatar Mar 12 '25 13:03 lukaisailovic

@lukaisailovic did following changes.

  • Made a separate test page for only checkout (/wagmi-checkout)
  • Remove Mainnet usage, enable only on testnet (base Sepolia and Optimism Sepolia) For sepolia weirdly unable to get the receipt after getting transaction hash so not included it right now.
  • Change custom address to vitalikEthAddress used in the repo for other tests.
  • Added the component to configure direct payment and remove defaults.
  • Added Checkout Receipt component

KannuSingh avatar Mar 12 '25 20:03 KannuSingh