WalletLink never renders

[jaeaster]

A typo prevents the built-in WalletLink provider from rendering.

Typo: https://github.com/Web3Modal/web3modal/blob/master/src/providers/providers/index.ts#L156

Failed condition resulting in shouldDisplayProvider == false https://github.com/Web3Modal/web3modal/blob/master/src/controllers/providers.ts#L108

[SimRunBot]

Not rendering for me as well.

Is it possible to remove the typo in my local install , before the PR gets confirmed and merged into the package src?

[jaeaster]

@SimRunBot You can use my fork, or create your own fork and apply the changes in the PR

npm install jeasterman/web3modal#master

[SimRunBot]

forked and implemented your typo fix, thank you that worked !!

[jkchuynh829]

I did the same thing and can't get the modal to render. Included a prepare script in my project. Am I missing something? @jeasterman @SimRunBot

edit: Fixed. rpc is required, contrary to the example which states it becomes optional if infura_id is provided.

[xzilja]

With stable version 2.0.0 of Web3Modal now released, we are officially dropping support for version 1.x Due to this this issue/pr was marked for closing. It is highly recommended to upgrade as 2.x will be receiving further updates that will enable functionality for some of our newer sdks like auth and push as well as support for WalletConnect v2 (See this post about WalletConnect v1 being deprecated https://medium.com/walletconnect/walletconnect-v1-0-sunset-notice-and-migration-schedule-8af9d3720d2e)

If you need to continue using Web3Modal 1.x and require this feature/fix implemented, we suggest adding it via forking V1 branch.