OAuth2 icon indicating copy to clipboard operation
OAuth2 copied to clipboard

Published 20 hours ago • verified publisher icon WP-API

Docs are still for OAuth1

Open kosso opened this issue 6 years ago • 3 comments

The documentation needs updating for OAuth2

https://github.com/WP-API/OAuth2/blob/master/docs/basics/Signing.md

kosso avatar Feb 25 '19 00:02 kosso

Never mind. I found these : https://developer.wordpress.com/docs/oauth2/

kosso avatar Feb 25 '19 01:02 kosso

Reopening this, since the documentation linked above is only for wordpress.com

kosso avatar May 30 '19 14:05 kosso

Updated docs would be great!

Outside of the existing docs, it would be good to have info on the use of wp_safe_redirect() and how to filter the list of external hosts; the change from wp_redirect() to wp_safe_redirect() in https://github.com/WP-API/OAuth2/commit/02d47e566731e23524ee027c051606b5480c1028#diff-e60a82a0cee7b25ba6509ae636d516db broke functionality, and it took quite a bit of work to figure out I needed to hook into allowed_redirect_hosts to fix things. If you'd like, I can submit a PR to add info about this, but I'm not sure where it should live.

runofthemill avatar Jan 16 '20 19:01 runofthemill