digital-credentials icon indicating copy to clipboard operation
digital-credentials copied to clipboard

Renamed IdentityRequestProvider to IdentityRequestDetails

Open marcoscaceres opened this issue 1 year ago • 1 comments

Closes #70


Preview | Diff

marcoscaceres avatar Feb 06 '24 01:02 marcoscaceres

Blocked on https://github.com/WICG/digital-identities/issues/74

marcoscaceres avatar Feb 07 '24 06:02 marcoscaceres

Given we moved away from the whole "identity" thing, I renamed it to DigitalCredentialsProvider instead. That makes more sense in the context of providers being an array.

I don't love "providers" tbh... but it's fine for now.

marcoscaceres avatar Jul 30 '24 04:07 marcoscaceres

Filed webkit bug https://bugs.webkit.org/show_bug.cgi?id=277323

marcoscaceres avatar Jul 30 '24 04:07 marcoscaceres

Given we moved away from the whole "identity" thing, I renamed it to DigitalCredentialsProvider instead. That makes more sense in the context of providers being an array.

I don't love "providers" tbh... but it's fine for now.

As I've tried to articulate previously, "Provider" and "providers" doesn't seem correct and is confusing to me. But the change away from "identity" makes sense.

bc-pi avatar Jul 31 '24 12:07 bc-pi

What if we called it DigitalCredentialsPresentationRequest? It is long but a bit better than providers IMO.

dictionary DigitalCredentialRequestOptions {
  sequence<DigitalCredentialsPresentationRequest> presentationRequests;
};

/cc @marcoscaceres @bc-pi

timcappalli avatar Jul 31 '24 14:07 timcappalli

What if we called it DigitalCredentialsPresentationRequest? It is long but a bit better than providers IMO.

Agree it's better than providers. Don't know if it's too long.

bc-pi avatar Jul 31 '24 16:07 bc-pi

I'd like to see consistency between singular and plural naming, and generally avoiding plurals, so here, DigitalCredentialPresentationRequest.

TallTed avatar Aug 01 '24 18:08 TallTed

LGTM and added chromium issue to the PR description:

https://g-issues.chromium.org/issues/357094234

samuelgoto avatar Aug 02 '24 17:08 samuelgoto

Ok, let's go with this for now. These are easy to change if we need to and, as stated, they are not web exposed things.

marcoscaceres avatar Aug 06 '24 00:08 marcoscaceres