digital-credentials
digital-credentials copied to clipboard
Renamed IdentityRequestProvider to IdentityRequestDetails
Blocked on https://github.com/WICG/digital-identities/issues/74
Given we moved away from the whole "identity" thing, I renamed it to DigitalCredentialsProvider instead. That makes more sense in the context of providers being an array.
I don't love "providers" tbh... but it's fine for now.
Filed webkit bug https://bugs.webkit.org/show_bug.cgi?id=277323
Given we moved away from the whole "identity" thing, I renamed it to
DigitalCredentialsProviderinstead. That makes more sense in the context ofprovidersbeing an array.I don't love "providers" tbh... but it's fine for now.
As I've tried to articulate previously, "Provider" and "providers" doesn't seem correct and is confusing to me. But the change away from "identity" makes sense.
What if we called it DigitalCredentialsPresentationRequest? It is long but a bit better than providers IMO.
dictionary DigitalCredentialRequestOptions {
sequence<DigitalCredentialsPresentationRequest> presentationRequests;
};
/cc @marcoscaceres @bc-pi
What if we called it
DigitalCredentialsPresentationRequest? It is long but a bit better than providers IMO.
Agree it's better than providers. Don't know if it's too long.
I'd like to see consistency between singular and plural naming, and generally avoiding plurals, so here, DigitalCredentialPresentationRequest.
LGTM and added chromium issue to the PR description:
https://g-issues.chromium.org/issues/357094234
Ok, let's go with this for now. These are easy to change if we need to and, as stated, they are not web exposed things.