digital-credentials icon indicating copy to clipboard operation
digital-credentials copied to clipboard

Use SecurityError for document state check

Open marcoscaceres opened this issue 1 year ago • 3 comments
trafficstars

We currently have an over-reliance on NotAllowedError (particularly in Cred Man). This makes things a bit more distinguishable (for interop testing), and lets developers know a bit more about what's going on.

The following tasks have been completed:

  • [ ] Modified Web platform tests (link)

Implementation commitment:

  • [ ] WebKit (link to issue)
  • [ ] Chromium (link to issue)
  • [ ] Gecko (link to issue)

Documentation and checks

  • [ ] Affects privacy
  • [ ] Affects security
  • [ ] Pinged MDN
  • [ ] Updated Explainer

Preview | Diff

marcoscaceres avatar Jul 16 '24 12:07 marcoscaceres

Blocked on tests and updating implementations.

marcoscaceres avatar Aug 09 '24 10:08 marcoscaceres

@samuelgoto, you ok with this change? If yes, I'll make them also in WebKit.

marcoscaceres avatar Aug 13 '24 07:08 marcoscaceres

@samuelgoto, you ok with this change?

Sounds reasonable to me to be more specific than NotAllowedError.

samuelgoto avatar Aug 22 '24 20:08 samuelgoto