attribution-reporting-api icon indicating copy to clipboard operation
attribution-reporting-api copied to clipboard

Shorten aggregation key id example

Open linnan-github opened this issue 3 years ago • 2 comments

The existing key id is actually longer than the limit and will fail.


Preview | Diff

linnan-github avatar Jun 08 '22 19:06 linnan-github

Would it be possible to document limits either in the explainer/spec as part of this change?

Ideally we could put it in the spec, although I am not sure if all of the parsing is in place for that. We could also just add placeholder constants in the spec with a TODO to use them

johnivdel avatar Jun 08 '22 19:06 johnivdel

Would it be possible to document limits either in the explainer/spec as part of this change?

Ideally we could put it in the spec, although I am not sure if all of the parsing is in place for that. We could also just add placeholder constants in the spec with a TODO to use them

Thanks John. Yeah, that makes sense. Added a placeholder for the constant in the spec. PTAL.

linnan-github avatar Jun 08 '22 20:06 linnan-github

@johnivdel @apasel422 could you PTAL, thanks!

linnan-github avatar Nov 30 '22 21:11 linnan-github