was-node-suite-comfyui icon indicating copy to clipboard operation
was-node-suite-comfyui copied to clipboard

comfyui was updated, which makes WNS unsuitable for it

Open godlockin opened this issue 1 year ago • 9 comments

https://github.com/comfyanonymous/ComfyUI/blob/eb0407e80657ab603a1251a653ad8b2e9e89c83c/comfy/model_management.py#L241C27-L241C33

by invoking the method, the following error would raised:

Error occurred when executing Text Multiline:

get_torch_device_name() missing 1 required positional argument: 'device'

File "/ComfyUI/execution.py", line 153, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
File "/ComfyUI/execution.py", line 83, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
File "/ComfyUI/execution.py", line 76, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
File "/ComfyUI/custom_nodes/was-node-suite-comfyui/WAS_Node_Suite.py", line 9444, in text_multiline
tokens = TextTokens()
File "/ComfyUI/custom_nodes/was-node-suite-comfyui/WAS_Node_Suite.py", line 835, in __init__
'[cuda_name]': comfy.model_management.get_torch_device_name(),

godlockin avatar Nov 14 '23 02:11 godlockin

Have the same issue

montyfi avatar Nov 14 '23 13:11 montyfi

Just checked in to report the same problem.

GalaxyTimeMachine avatar Nov 14 '23 13:11 GalaxyTimeMachine

same issue here

alenknight avatar Nov 14 '23 17:11 alenknight

This was a WAS suite change, not a ComfyUI one. https://github.com/WASasquatch/was-node-suite-comfyui/commit/75396f76af68f501d703ff1c0ecde95c983af684

WeeBull avatar Nov 14 '23 20:11 WeeBull

Im getting the same error

Takeover713 avatar Nov 14 '23 21:11 Takeover713

Can confirm, all goes boom.

sh1ny avatar Nov 14 '23 22:11 sh1ny

This should have already been patched moments after the initial patch. Weird. I guess git failed to push (I have sat net)

WASasquatch avatar Nov 14 '23 23:11 WASasquatch

Confirming patch here: https://github.com/WASasquatch/was-node-suite-comfyui/commit/4e53775e650a7e2d2d1d73056bb914d7edc57f69

WASasquatch avatar Nov 14 '23 23:11 WASasquatch

thank you!

Takeover713 avatar Nov 14 '23 23:11 Takeover713