was-node-suite-comfyui icon indicating copy to clipboard operation
was-node-suite-comfyui copied to clipboard

Request to update support for Numpy==1.26

Open ZTWY35 opened this issue 1 year ago • 3 comments

My Comfyui always automatically updates Numpy to version 1.26 every time it starts up, but was-node-suite-comfyui only supports up to version 1.24, which conflicts.I hope it can be updated to support Numpy==1.26.Thank you.

ZTWY35 avatar Nov 06 '23 13:11 ZTWY35

Remove the pinned version from requirements. I don't even remember what needed numpy so low. Probably blip which needs old transformers. But you should be fine unless you run into that one node that does need it.

WASasquatch avatar Nov 06 '23 15:11 WASasquatch

was-node-suite-comfyui module for custom nodes: Numba needs NumPy 1.24 or less 。

Once I upgrade other plugins, there are still errors.

cardenluo avatar Jan 30 '24 13:01 cardenluo

Naturally, when something like WAS-NS needs to downgrade dependencies, you install it last. If you upgrade other plugins, they run their requirements, and upgrade deps. So the lower versions, like numpy, transformers, etc get upgraded often.

WASasquatch avatar Jan 30 '24 18:01 WASasquatch