geeknote
geeknote copied to clipboard
VitaliyRodnenko
http_proxy support needed.
This is a great application. It should support the http_proxy natively. I'm not able to install geeknote behind proxy. I'm not able to use geeknote behind proxy.
At least, you can install Geeknote since setup.py supports HTTP proxies. Please check my last comment on #293.
This is partly a python_thrift issue. I encourage everyone encountering the problem to vote for https://issues.apache.org/jira/browse/THRIFT-3798 and/or https://issues.apache.org/jira/browse/THRIFT-3507. Once it's fixed in python_thrift, evernote could pull in the updated thrift (or stop using patched thrift altogether). Even if evernote didn't do that, geeknote users could install an updated python_thrift to enable proxy support. That's not the whole story though, additional patches for geeknote's oauth module are required as well.
@wxjeacen, check out my branch, and read the proxy support README. The related pull request is already 5 months old, Vitaly doesn't seem to be much interested.
@wxjeacen, please also visit the thrift bug reports I mentioned on the Apr 27 comment, and vote.
@mwilck , When I was patching the thrift, it reported error.
curl https://issues.apache.org/jira/secure/attachment/12801233/0001-python-THttpClient-Add-support-for-system-proxy-sett.patch | git am % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 102 2768 102 2768 0 0 1022 0 0:00:02 0:00:02 --:--:-- 7381 Applying: python/THttpClient: Add support for system proxy settings error: patch failed: lib/py/src/transport/THttpClient.py:63 error: lib/py/src/transport/THttpClient.py: patch does not apply Patch failed at 0001 python/THttpClient: Add support for system proxy settings The copy of the patch that failed is found in: /home/shwang/thrift/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
@wxjeacen, make sure you have the correct thrift version, as explained in the proxy support README (git checkout -b proxy e363a34e63). The latest TRUNK of thrift 1.0.x doesn't need these patches any more, they've been merged a few weeks ago.