git-machete-intellij-plugin icon indicating copy to clipboard operation
git-machete-intellij-plugin copied to clipboard

Use Gradle toolchain instead of `if (JavaVersion.current() != JavaVersion.VERSION_11)`

Open PawelLipski opened this issue 3 years ago • 5 comments

https://docs.gradle.org/current/userguide/toolchains.html

PawelLipski avatar Jul 08 '22 09:07 PawelLipski

@PawelLipski Can I take this issue?

salmansharifov avatar Jul 10 '22 20:07 salmansharifov

Sure! pls open a PR from your fork to develop branch in this project

PawelLipski avatar Jul 10 '22 20:07 PawelLipski

Hey @salmansharifov, are you going to work on that?

PawelLipski avatar Jul 30 '22 11:07 PawelLipski

TBD if it still makes sense now that the build supports both Java 11 and 17 though

PawelLipski avatar Aug 27 '22 22:08 PawelLipski

Might be revisited when Java 11 support is dropped (#859)

PawelLipski avatar Aug 27 '22 22:08 PawelLipski

Plugins for IntelliJ 2022.3 must be built on JDK 17 anyway (https://github.com/VirtusLab/git-machete-intellij-plugin/pull/1201)

PawelLipski avatar Oct 01 '22 20:10 PawelLipski