objection.js icon indicating copy to clipboard operation
objection.js copied to clipboard

Published 20 hours ago • verified publisher icon Vincit

fix: Generic static This.

Open max-kahnt-keylight opened this issue 2 years ago • 2 comments

Attempt to fix https://github.com/Vincit/objection.js/issues/2531. Should probably be extended to be used in all static This inferences.

max-kahnt-keylight avatar Oct 06 '23 14:10 max-kahnt-keylight

i know this is a while ago, but can you give an example of what was broken before? Since this is not maintained anymore, I am ingesting all fixes into my fork. This seems similar to lots of other typescript fixes that were already proposed and merged into my fork. Woudl love to add your fix too

1mike12 avatar Jul 22 '24 16:07 1mike12

I am not sure what additional context to give apart from the issue #2531 that is already linked. It seems like this fix is/was needed in order to have the changes from #2399 (which has been reverted).

max-kahnt-keylight avatar Jul 23 '24 05:07 max-kahnt-keylight

This looks reasonable. @max-kahnt-keylight could you follow up with another PR to use the same approach in all static this inferences?

lehni avatar Sep 25 '24 11:09 lehni

💚 Very much appreciated that you are getting back to this even though the issue currently doesn't haunt me personally.

I created https://github.com/Vincit/objection.js/pull/2700 now. I am not sure if I will be able to test it reasonably and push its finalization, but I think it definitely makes sense to have this in all such places 👍🏼

max-kahnt-keylight avatar Sep 25 '24 11:09 max-kahnt-keylight