objection.js icon indicating copy to clipboard operation
objection.js copied to clipboard

Published 20 hours ago • verified publisher icon Vincit

filters/modify on join table of m2m relations

Open falkenhawk opened this issue 6 years ago • 3 comments

addressing https://github.com/Vincit/objection.js/issues/1356

I am not sure if I tackled it from the right direction... and I haven't wrote any tests, but hopefully you could give me some hints what should I do to make this PR complete

falkenhawk avatar Aug 01 '19 13:08 falkenhawk

Coverage Status

Coverage increased (+0.002%) to 97.175% when pulling 094f8abcda9a95055f199b79f918ebbe9e0cc84d on ovos:m2m-join-table-modify into 5aa7dd0f2d7e6380388c8df8d118a8d3fcff3fc0 on Vincit:master.

coveralls avatar Aug 01 '19 13:08 coveralls

@koskimas would you consider this for objection v3.0? I could try to rebase and add tests, but not sure if I could make it on time, depends when you would like to move out of v3 alpha stage

falkenhawk avatar Jul 19 '21 07:07 falkenhawk

@koskimas I've added some tests and adjusted docs.

falkenhawk avatar Nov 08 '21 16:11 falkenhawk

@kibertoad would you mind to take a look at this PR and review it while you are at it, please? It's the oldest among currently open PRs. Hopefully it has matured enough ;)

falkenhawk avatar Mar 31 '23 15:03 falkenhawk

LGTM, thanks @falkenhawk!

As for the OnErrorOperation bit, I think it's not wrong to leave this in. Merging.

lehni avatar Apr 16 '23 18:04 lehni

The new API is not doing anything and both filter and modify are ignored.

developer239 avatar Apr 01 '24 17:04 developer239