Vincent Langlet

> There should be the principle of least surprise applied here. I was surprised that [57b3722](https://github.com/phpstan/phpstan-src/commit/57b37222fe0e3142a0e2f2717c229ab1b8ad4713) doesn't work as expected because `@phpstan-type` should be applied as local substitution. Meaning that...

Is there anything I can do to move this PR forward @ondrejmirtes I found another issue similar to `@phpstan-type` but for `@throws` tag. Cf https://github.com/phpstan/phpstan-symfony/pull/302 I see three solutions here:...

Hi @StefanGramadnikov While you debug, did you find what should be written instead of ``` $types[] = $meta->associationMappings[$idField]['type']; $params[] = $meta->reflFields[$idField]->getValue($entity); ``` then ?

It's because psalm has a specific ReturnTypeProvider for array_filter. https://github.com/vimeo/psalm/blob/4.x/src/Psalm/Internal/Provider/ReturnTypeProvider/ArrayFilterReturnTypeProvider.php It require to do the same for Collection::filter in this repository https://github.com/psalm/psalm-plugin-doctrine/tree/2.x/src/Provider/ReturnTypeProvider

If we add keys to the map method, maybe the key should be the first param to add consistency with others methods. See https://github.com/doctrine/collections/issues/251

> Any utility methods taking a closure as argument would be methods that cannot be implemented in optimized way by persistent collections (as the closure can do anything). And so...

I feel like it's too bad to not create a new major version with useful method added to the collection interface. There is a method contains, exists or filter and...

> That's an issue we have both in Doctrine and Sonata: major versions are a big deal. They wouldn't be if we had them more frequently (or at all, really)....

> > `forAll` goal is to compare if all items in the collection satisfy a given predicate. So, it will execute the Closure on each item **while true is being...

> Can you guys take a look at idea? Do you think it is worth it? Symfony project started to add some template in their code. For instance: https://github.com/symfony/symfony/pull/45696. I...