operator icon indicating copy to clipboard operation
operator copied to clipboard

Published 20 hours ago • verified publisher icon VictoriaMetrics

fix(vmalert): discover vmalertmanagers

Open uhthomas opened this issue 2 years ago • 3 comments

Related: #702

uhthomas avatar Jul 24 '23 21:07 uhthomas

Upon further thinking and reading, I'm not sure it will fix the linked issue. However, it definitely does address some problematic assumptions made by the original filtering code. There are a few scenarios where it will do the complete wrong thing, which isn't ideal.

uhthomas avatar Jul 24 '23 22:07 uhthomas

Upon further thinking and reading, I'm not sure it will fix the linked issue. However, it definitely does address some problematic assumptions made by the original filtering code. There are a few scenarios where it will do the complete wrong thing, which isn't ideal.

Thanks for the pr! Can you add some scenarios that could be wrong for the origin code in the test file?

Haleygo avatar Jul 26 '23 06:07 Haleygo

@Haleygo Will do.

uhthomas avatar Jul 26 '23 23:07 uhthomas