VictoriaMetrics icon indicating copy to clipboard operation
VictoriaMetrics copied to clipboard

bug fix : ApplyRelabeling change metricName which result in the chan…

Open foreverm10 opened this issue 3 years ago • 2 comments

The relabel function in vminsert has the following bugs

  1. Unmatched labels may also be modified, resulting in a large time complexity, causes the service to be unavailable
  2. All labels whose labenName is __name__ will become null after Relabel, which will cause the selected label to change after Relabel is enabled, resulting in the change of the route selected by the storage. As a result, storage index writes increase, resulting in service write backlog or even crash

foreverm10 avatar Mar 02 '22 09:03 foreverm10

@foreverm10 , kindly ping regarding the missing test case for the fixed issue

valyala avatar Aug 07 '22 21:08 valyala

@foreverm10 , kindly ping regarding the missing test case for the fixed issue

after start the relabel function ,GetStorageIdx()return different storageNodeIdx between { Name: "__name__", Value: "foo" } and { Name: "", Value: "foo", } As a result, the storageNodeIdx change after start the relabel function ,which result in a lot of data is written to new nodes ,storage index writes increase, resulting in service write backlog or even crash @valyala

foreverm10 avatar Aug 09 '22 09:08 foreverm10