fhir-kit-client icon indicating copy to clipboard operation
fhir-kit-client copied to clipboard

Conditionally import cross-fetch with polyfill - Issue #197

Open taylorkle opened this issue 2 years ago • 1 comments

Allow developers to conditionally import the optional polyfill with the cross-fetch package to address issue 197 https://github.com/Vermonster/fhir-kit-client/issues/197

It is unclear if the entire package cross-fetch with ponyfill caused the issue or the use of polyfill alone, but we could consider testing with disabled polyfill first. The polyfill is only applied in the absence of global fetch.

taylorkle avatar Oct 27 '23 15:10 taylorkle

Looks good and will work, but I think we could probably just remove the polyfill and allow users who need it to load it. This blog post suggests that as well.

https://www.builder.io/blog/stop-polyfilling-fetch-in-your-npm-package

jpowers avatar Nov 01 '23 13:11 jpowers