KiBuzzard
KiBuzzard copied to clipboard
VedantParanjape
Merge back into KiBuzzard?
Hey @VedantParanjape,
If you haven't seen. I've updated my plugin to better support V5.1 and Windows/MacOS/Linux. It now also has preview support, does it make sense to keep this fork separate now?
If there are any changes that you've made over here that I can incorporate back into the main plugin? Just hoping to avoid confusion about versions/etc and avoid duplicating work for folks that want to add features.
Hey @gregdavill Sounds good.
If there are any changes that you've made over here that I can incorporate back into the main plugin?
Mostly the answer is no, I and @dcelectr have mostly worked on merging changes in the upstream repo back here. I'll let you know though, after a discussion with him :)
Great :D
Give the original plugin a try sometime, and let me know what you think. We're now 100% free from any pip dependencies, and everything should work on both KiCad 5.1 and Nightly. On MacOS, Windows, Linux.
The goal here is to keep the same code base for both versions so that no one misses out on new features, and we're not wasting work porting features across.
@gregdavill
I just tested the original plug-in (your) for v5.1.9 on both Windows 10 and Debian 10,
On Linux, I git clone recursively and and only pip3 install svg2mod --user to add a dependency that I knew I was missing before I even tried the original plug-in. (On Windows 10, I do not have git installed; so, I downloaded the files (and the dependences) from the web interface (and added the dependencies in the proper subfolders).
In both Linux and Windows, the original plug-in worked (I did a few labels, but nothing extensive).
I have python v3.8 on Windows and v3.7 on Linux.
On Linux, I git clone recursively and and only
pip3 install svg2mod --user
You shouldn't need to use pip at all... Just git clone recursive, the submodules include a version of svg2mod that's compatible with python2.7 (for OSX support) and has a few other small tweaks that improve font rendering.
In both Linux and Windows, the original plug-in worked (I did a few labels, but nothing extensive).
Great, that matches my experience as well.
I actually wasn't aware that submodules didn't download with a zip version of the repo..
~Might be easier to store these directly in the repo then... I'd like to ensure folks without git can use the plugin.~
Edit: I've now switched the repo from submodules to subtrees. So you can use githubs 'downoad as zip option' without any extra steps now.
I actually wasn't aware that submodules didn't download with a zip version of the repo..
~Might be easier to store these directly in the repo then... I'd like to ensure folks without git can use the plugin.~
Edit: I've now switched the repo from submodules to subtrees. So you can use githubs 'downoad as zip option' without any extra steps now.
or you could add releases. I'll check your repo today and let you know if it works :)
Hey @gregdavill, I tried this. It works fine on my linux mint 20 system. I'll archive this repo and point it to your repo.
One nitpick, I get this warning on running it.
PS: Sorry for the delay, I was engaged with college assignments :P