solady icon indicating copy to clipboard operation
solady copied to clipboard

♻️ Rename all `rawOp` functions to `_op`?

Open Vectorized opened this issue 1 year ago • 1 comments
trafficstars

The problem with prefixing it with "unsafe" or "raw" makes stuff super verbose.

And results in inconsistencies like toWadUnsafe vs unsafeMulWad; which I understand is because unsafeToWad just sounds werid.

The _op nomenclature has been used in SIMD intrinsics like _mm256_xor, and feels more natural.

With this renaming, we can have stuff like _expWad, _lnWad, without feeling awkward.

Still, there are some advantages of "raw" prefix:

  • Auditoors immediately know it's raw.
  • Easy to codeslaw. I can track down who are using Solady's FixedPointMathLib.

I'll probably leave this up for a few weeks before deciding.

Most probably will stick to no change.

Vectorized avatar Dec 14 '23 16:12 Vectorized

I don't like safe and similar that want to add some semantics but not super verifiable (so, it's like "why").

++ on _op or similar more functional term.

z0r0z avatar Dec 30 '23 01:12 z0r0z