Quic.NET icon indicating copy to clipboard operation
Quic.NET copied to clipboard

Shift to .NET Core

Open NotoriousRebel opened this issue 5 years ago • 10 comments
trafficstars

It would be great if this project was targeting .NET Core especially with 3.1 getting LTS for 3 years :)

NotoriousRebel avatar Mar 09 '20 01:03 NotoriousRebel

Any updates?

NotoriousRebel avatar Apr 29 '20 03:04 NotoriousRebel

Have a look at my fork and netstandard branch (https://github.com/stevehayles/Quic.NET/tree/netstandard) which is multi-targetting .net4.5.2 and Netstandard2.1

I believe this is a better way to go than specifically creating creating a .NET Core library. This library doesn't need anything outside .NetStandard (at least yet) and this makes it compatible in the widest sense with as many projects as possible

stevehayles avatar May 24 '20 09:05 stevehayles

Hello, @stevehayles ,

thank you for doing so. Currently, your link does not point to any branch, has it been deleted?

Vect0rZ avatar Jun 01 '20 18:06 Vect0rZ

Hi @Vect0rZ ,

My mistake with the url, I think that should point to the correct fork / branch now

stevehayles avatar Jun 02 '20 08:06 stevehayles

Great, thank you @stevehayles , looks good

If that's okay for you, let's do a PR and merge it into the main repository.

Vect0rZ avatar Jun 02 '20 08:06 Vect0rZ

@Vect0rZ Very happy to do a PR, I am actually just checking through the .NET Standard versions as I think it could be dropped to 2.0 which will allow usage with .NET core 2.0, Mono 5.4 and a lower version of Unity.

If that is the case than the full framework would be compatible from version 4.6.1 which would make the multi-targetting to 4.5.2 almost redundant. How important do you think 4.5.2 compatibility is in reality ?

stevehayles avatar Jun 02 '20 10:06 stevehayles

@stevehayles Good point about Core 2.0. Not worried at all about 4.5.2 compatibility at this point in the development stage, and I doubt there will be an emerging demand for it. In the unlikely event somebody requests it, we can easily branch and do a specific release.

Thanks!

Vect0rZ avatar Jun 02 '20 10:06 Vect0rZ

@NotoriousRebel @stevehayles Any concerns closing this task?

Vect0rZ avatar Jul 07 '20 08:07 Vect0rZ

@Vect0rZ No problem for me, it's working fine here. Now to work on the streaming .....

stevehayles avatar Jul 07 '20 08:07 stevehayles

Fine with it being closed thanks for all the help.

NotoriousRebel avatar Jul 07 '20 13:07 NotoriousRebel