VasuDevrani

does this still holds?

@lowang-bh It seems no one working on this, can I take this up?

so i was working on this and for the step to run test ```yaml - name: Run tests and generate coverage report run: | make unit-test go test ./... -coverprofile=coverage.out...

> @VasuDevrani Should we also fix those errors in the scope of this PR? maybe yes (but they are a lot), I think the CI failing because of those.

> You can use the attribute `[[maybe_unused]]`. Wouldn't it be better to drop the unused parameter and keep the type only ```c virtual Status ToNumber(int64_t*) const { return {Status::NotOK, "not...

Two more concerns, then I'll move forward with `[[maybe_unused]]`: - it can make code a bit unreadable (especially if there's multiple unused params together) ```c void performOperation(const Config& config, [[maybe_unused]]...

> We already uses C++17, isn't we? yes

do we want INFO command to return output in json fomat when `INFO JSON` (JSON specified in command) otherwise plain text?

im struggling with parsing the output to json,[ this line of ](https://github.com/VasuDevrani/kvrocks/blob/unstable/src/server/server.cc?plain=1#L1188) code outputs string which looks like `"# Clients\r\nmaxclients:10000\r\nconnected_clients:1\r\nmonitor_clients:0\r\nblocked_clients:0\r\n"` using `jsoncons::json::parse` throws ser_error (unsupported format) and I should not...

> TBH I cannot get your point. Why do you want to parse it as JSON? It's just not JSON. Maybe i misunderstood, please confirm. The issue wants the support...