ABRoot icon indicating copy to clipboard operation
ABRoot copied to clipboard

Lockfile doesn't get removed after an operation

Open matbme opened this issue 1 year ago • 8 comments
trafficstars

When running an upgrade or apply operation, the lockfile remains in /tmp even after a reboot, which prevents running any other operation until it is manually deleted.

matbme avatar May 08 '24 14:05 matbme

I can't reproduce this. After an upgrade, the lock file is successfully removed. The issue I see is that it is created when trying to auto-upgrade on boot.

taukakao avatar May 08 '24 16:05 taukakao

Weird. I can reproduce this in both a fresh install and an older one after updating. I'll look deeper into this when I have the time.

matbme avatar May 08 '24 20:05 matbme

@matbme Are you checking right after the upgrade or after the reboot?

taukakao avatar May 08 '24 21:05 taukakao

@matbme Are you checking right after the upgrade or after the reboot?

Both. It's there before and after the reboot.

matbme avatar May 08 '24 23:05 matbme

Yeah, so after rebooting it is actually cleared but then abroot is executed by vso so the lockfile is there again.

taukakao avatar May 09 '24 00:05 taukakao

image the lock disappear both when it fails or succeed so I think that transaction was still running so the lock file was being preserved, the only reason the lock file don't get deleted is in case abroot crashes or get killed, which I think is not the case.

Since I am not able to replicate, can anyone tell me if abroot is still running when that happen?

mirkobrombin avatar May 11 '24 21:05 mirkobrombin

@mirkobrombin Abroot is not running when the lock file exists after upgrading.

Note that abroot is being started multiple times (3-4 times) by vso which might have something to do with this.

taukakao avatar May 13 '24 10:05 taukakao

Maybe the sysd timer is not working as expected and then keep running it

mirkobrombin avatar May 13 '24 14:05 mirkobrombin