Ivan Tanev

Results 44 comments of Ivan Tanev

I ran into a similar problem - basically when dealing with FKs you need a `SET FOREIGN_KEY_CHECKS = 0;` before everything and `SET FOREIGN_KEY_CHECKS = 1;` at the end (for...

https://github.com/davidkpiano/xstate/pull/2235/commits/3d86fed43b46a2a7caf5e2011e3198736af6bbd1 and https://github.com/davidkpiano/xstate/pull/2235/commits/433887fd24ad9219c8da528fbaf685e35aa9a241 fix the errors the script found. Now the output is: ``` ➜ xstate git:(doc/fix-typescript-guide) yarn verifyTypescriptExamples yarn run v1.22.10 $ find packages docs -iname '*.md' -not -path...

Should most (all?) example code be rewritten in TS? I did that for `context.md` (not published) but then stopped because I'm not sure if this is desirable - I mean,...

OK, added the `condext.md` TS rewrite!

I also added the ability to verify JS, but have not fixed the errors that show up: ``` $ VERIFY_JS=1 yarn verifyCodeExamples yarn run v1.22.10 $ find packages docs -iname...

> q: would https://github.com/shikijs/twoslash provide similar functionality (and more)? It does! However, it wasn't released at the time I wrote this PR, and integration seems non-trivial. Do you think the...

This is ready for re-review. I think it would be useful to merge as is and consider moving to `twoslash` in the future when someone has the time to do...

> My only question now is how approachable these examples are going to be to those using JavaScript, and not TypeScript? Should we find a way to allow developers to...

OK. I don't have the bandwidth to do both right now, not sure when I will.