vdf icon indicating copy to clipboard operation
vdf copied to clipboard

Published 20 hours ago • verified publisher icon ValvePython

I think, single quotation do not need escape.

Open aoisensi opened this issue 5 years ago • 4 comments

At least Dota 2 interprets \' as they are.

aoisensi avatar Sep 14 '20 09:09 aoisensi

Could you the a file that reproduces the issue?

rossengeorgiev avatar Dec 06 '20 15:12 rossengeorgiev

https://raw.githubusercontent.com/dotabuff/d2vpkr/master/dota/resource/dota_english.txt Ctrl+F and find '.

aoisensi avatar Dec 08 '20 12:12 aoisensi

So the issue is that when you dump a dict, then ' are escaped, correct?

Here are all the characters they escape from the SDK, which includes ': https://github.com/ValveSoftware/source-sdk-2013/blob/0d8dceea4310fde5706b3ce1c70609d72a38efdf/mp/src/tier1/utlbuffer.cpp#L54-L69

I guess the only way to resolve this is introducing a parameter to enable/disable escaping. That will also resolve #28

rossengeorgiev avatar Jan 23 '21 13:01 rossengeorgiev

Yes. But, I want to exclusion only '. I need to escape another characters. The SDK is Source1. Dota2's SDK is Source2. Perhaps the parser of Source1 is not the same as the parser of Source2. I'm using edited version of this library. https://github.com/nihongoka/dota2/blob/7e19285702203957ecb2b50b88de97241305515b/scripts/vdf/init.py#L61 https://github.com/ValvePython/vdf/blob/master/vdf/init.py#L62 Sorry for late.

aoisensi avatar Jan 29 '21 10:01 aoisensi