GoodbyeDPI icon indicating copy to clipboard operation
GoodbyeDPI copied to clipboard

Published 20 hours ago • verified publisher icon ValdikSS

Added initial cmake build support

Open KOLANICH opened this issue 7 years ago • 4 comments

Added initial cmake build support. Fixed according to the latest WinDivert. closes #79.

KOLANICH avatar May 22 '18 17:05 KOLANICH

To be continued... Keep it up 👍 👍 👍

sgeto avatar May 22 '18 21:05 sgeto

Cmake is a good build system and generally I am for it, but probably not right now. GoodbyeDPI most probably would face refactoring and Linux/macOS support in the near future, that is where cmake would be handy and I appreciate your pull request, but I would postpone to merge it.

ValdikSS avatar Jun 26 '18 19:06 ValdikSS

CMake is immediately useful, because it is not only for crossplatform build, but also for crosstoolchain one. I mean that it allows build projects with such different compilers (MSVC, GCC, Intel, clang (in MSVC and gcc modes) ) and build systems (make, nmake, ninja) with minimal compiler-specific code. Please note, that some refactoring, hardening and bug-fixing was also done. I insist on merging this as soon as possible. When the tool became cross-platform, you would be able to update the stuff to reflect the new state.

KOLANICH avatar Jun 26 '18 19:06 KOLANICH

I just realized I haven't submitted my comments.

ValdikSS avatar Jul 19 '18 13:07 ValdikSS