Vim icon indicating copy to clipboard operation
Vim copied to clipboard

WIP: Handling jk motion for cjk and full width characters

Open smokyabdulrahman opened this issue 9 months ago • 0 comments

What this PR does / why we need it: To handle full width character correctly (as VSCode does and neovim/vim) on jk motions Which issue(s) this PR fixes This is to address issue: https://github.com/VSCodeVim/Vim/issues/4096

Special notes for your reviewer: The code is WIP (needs cleaning after making sure things work), the changes broke the logic of desiredColumn property. I am trying to understand why we need it (since VSCode already handles this properly), and how to fix it.

If anybody want to contribute to the PR, please do so, or at least share your ideas ❤️.

helpful files from VSCode repo: https://github.com/microsoft/vscode/blob/f253ed1e6c2868ba648681a3a7942603c2ba836b/src/vs/editor/common/cursor/cursorMoveOperations.ts#L157 https://github.com/microsoft/vscode/blob/main/src/vs/editor/common/core/cursorColumns.ts#L25 https://github.com/microsoft/vscode/blob/main/src/vs/base/common/strings.ts#L687

smokyabdulrahman avatar Feb 01 '25 21:02 smokyabdulrahman