pyvroom icon indicating copy to clipboard operation
pyvroom copied to clipboard

`max_load` input for `breaks` object not currently supported

Open ejwillemse opened this issue 2 years ago • 2 comments

Currently, vroom 1.3.0 supports a max_load input with the breaks object:

[max_load]: an array of integers describing the maximum vehicle load for which this break can happen --- https://github.com/VROOM-Project/vroom/blob/master/docs/API.md

pyvroom 1.3.0 only allows for id, time_windows, service and description (see https://github.com/VROOM-Project/pyvroom/blob/9965ce244d01252bbcedcfafe22dc01a7138133a/src/vroom/break_.py#L33):

    def __init__(
        self,
        id: Union[Break, int],
        time_windows: Sequence[TimeWindow] = (),
        service: int = 0,
        description: str = "",
    ) -> None:

Would it be easy to include max_load input with pyvroom as well?

ejwillemse avatar May 03 '23 21:05 ejwillemse

That is a good catch, and something I missed in the recient release.

I've made a fix in version 1.13.1. Let me know if it works as expected.

jonathf avatar May 06 '23 08:05 jonathf

Thanks, I'll do some testing later next week and will close the issue once tested.

ejwillemse avatar May 07 '23 19:05 ejwillemse