webrtc-issue-detector icon indicating copy to clipboard operation
webrtc-issue-detector copied to clipboard

feat: added ability to specify id for pc

Open IlgamGabdullin opened this issue 1 year ago • 0 comments

Discussed issue here

Added new optional id?: string param in handleNewPeerConnection method and emited the id back in callback calculateNetworkScores, so now developers can use it that way

webRTCIssueDetector.handleNewPeerConnection(pc, 'some-id-1')
webRTCIssueDetector.handleNewPeerConnection(pc, 'some-id-2')
webRTCIssueDetector.handleNewPeerConnection(pc, 'some-id-3')

and in callback it wil be

onNetworkScoresUpdated: (scores) => scores.id; // some-id-X

@evgmel @desher @panov-va please take a look

IlgamGabdullin avatar May 08 '24 13:05 IlgamGabdullin