Tony Brix

Results 612 comments of Tony Brix

Going to close this as stale. If you would like to continue working on it feel free to reopen it

I think a better fix would be to end the line on move if the button isn't pressed. That would fix mouseup outside the browser as well.

We should probably do both, fire endStroke on window.mouseup or window.mousemove if mouseup was never called. My only concern with using `window` instead of `canvas.ownerDocument` is breaking #636 if the...

I created a POC of how I think the event listeners should change in #703. I listen for `pointerup` on `window` and `canvas.ownerDocument`. I also added `pointerleave` and `pointerenter` liseners...

The signature is created by adding Bezier curves so the drawing follows closer to the place the user actually signed instead of lines connecting points that we happened to detect....

If you want to create a PR we could see how it looks. 😁👍

Now the error I get is `TypeError: Scanner is not a constructor`. I think this has to do with the fact that Scanner is a default export and abbreviation just...

Uninstall it and try `apm install https://github.com/bus-stop/x-terminal`