ROS-TCP-Endpoint icon indicating copy to clipboard operation
ROS-TCP-Endpoint copied to clipboard

Added the ip and port as launch arguments in the ros2 launch file

Open Elie-Y opened this issue 3 years ago • 2 comments

Proposed change(s)

Modified the ros2 launch file by adding the Ip and Port as launch arguments

Types of change(s)

  • [ ] Bug fix
  • [x] New feature
  • [ ] Code refactor
  • [ ] Documentation update
  • [ ] Other (please describe)

Testing and Verification

I tested it using ROS2 Galactic, ros2 launch ros_tcp_endpoint endpoint.py ROS_IP:=127.0.0.1 ROS_TCP_PORT:=10001

Test Configuration:

  • Unity Version: [e.g. Unity 2020.3.30f1]
  • Unity machine OS + version: Linux mint 20.3 Cinnamon
  • ROS machine OS + version: Linux mint 20.3 Cinnamon, ROS2 Galactic
  • ROS–Unity communication: Direct, Docker

Checklist

  • [x] Ensured this PR is up-to-date with the dev branch
  • [x] Created this PR to target the dev branch
  • [x] Followed the style guidelines as described in the Contribution Guidelines
  • [ ] Added tests that prove my fix is effective or that my feature works
  • [ ] Updated the Changelog and described changes in the Unreleased section
  • [ ] Updated the documentation as appropriate

Other comments

Elie-Y avatar Apr 28 '22 08:04 Elie-Y

CLA assistant check
All committers have signed the CLA.

unity-cla-assistant avatar Apr 28 '22 08:04 unity-cla-assistant

BTW: The naming of the parameters is inconsistent with the ROS1 version. There the parameters are tcp_ip and tcp_port. Also the internal variables are called likewise. See #123 why the ROS1 naming might be preferable.

StephanHasler avatar May 12 '22 07:05 StephanHasler