CHANGE: Removed isInBatchMode and isPaused from IInputRuntime (ISX-2323)

[ekcoh]

Description

Remove isInBatchMode from IInputRuntime and implementations, the interface is internal and there is no need for this property to be part of the internal run-time interface since it is related to the application and there is currently no need to control it in test fixture. If this later would need stubbing it is suggested the Input System uses a dedicated IApplication interface if desirable to mock the application to separate concerns.

Testing status & QA

Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.

Rerunning automated tests only.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

• Complexity: Small
• Halo Effect: Small

Comments to reviewers

No changeling entry added since completely internal.

Checklist

Before review:

• [ ] Changelog entry added.
  • Explains the change in Changed, Fixed, Added sections.
  • For API change contains an example snippet and/or migration example.
  • JIRA ticket linked, example (case %<ID>%). If it is a private issue, just add the case ID without a link.
  • Jira port for the next release set as "Resolved".
• [ ] Tests added/changed, if applicable.
  • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
  • Performance tests.
  • Integration tests.
• [ ] Docs for new/changed API's.
  • Xmldoc cross references are set correctly.
  • Added explanation how the API works.
  • Usage code examples added.
  • The manual is updated, if needed.

During merge:

• [ ] Commit message for squash-merge is prefixed with one of the list:
  • NEW: ___.
  • FIX: ___.
  • DOCS: ___.
  • CHANGE: ___.
  • RELEASE: 1.1.0-preview.3.

After merge:

• [ ] Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

[codecov-github-com[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

@@           Coverage Diff            @@
##           develop    #2195   +/-   ##
========================================
  Coverage    67.79%   67.79%           
========================================
  Files          367      367           
  Lines        53528    53526    -2     
========================================
  Hits         36290    36290           
+ Misses       17238    17236    -2     

Flag	Coverage Δ
mac_2021.3_pkg	5.41% <100.00%> (-0.01%)	:arrow_down:
mac_2021.3_project	70.43% <100.00%> (+<0.01%)	:arrow_up:
mac_2022.3_pkg	5.19% <100.00%> (-0.01%)	:arrow_down:
mac_2022.3_project	65.29% <100.00%> (+<0.01%)	:arrow_up:
mac_6000.0_pkg	5.20% <100.00%> (-0.01%)	:arrow_down:
mac_6000.0_project	67.71% <100.00%> (+<0.01%)	:arrow_up:
mac_6000.1_pkg	5.20% <100.00%> (-0.01%)	:arrow_down:
mac_6000.1_project	67.71% <100.00%> (+<0.01%)	:arrow_up:
mac_6000.2_pkg	5.20% <100.00%> (-0.01%)	:arrow_down:
mac_6000.2_project	67.70% <100.00%> (+<0.01%)	:arrow_up:
mac_trunk_pkg	5.20% <100.00%> (-0.01%)	:arrow_down:
mac_trunk_project	67.70% <100.00%> (-0.01%)	:arrow_down:
win_2021.3_pkg	5.42% <100.00%> (-0.01%)	:arrow_down:
win_2021.3_project	70.50% <100.00%> (-0.01%)	:arrow_down:
win_2022.3_pkg	5.19% <100.00%> (-0.01%)	:arrow_down:
win_2022.3_project	65.36% <100.00%> (+<0.01%)	:arrow_up:
win_6000.0_pkg	5.20% <100.00%> (-0.01%)	:arrow_down:
win_6000.0_project	67.79% <100.00%> (+0.01%)	:arrow_up:
win_6000.1_pkg	5.20% <100.00%> (-0.01%)	:arrow_down:
win_6000.1_project	67.78% <100.00%> (+<0.01%)	:arrow_up:
win_6000.2_pkg	5.20% <100.00%> (-0.01%)	:arrow_down:
win_6000.2_project	67.78% <100.00%> (+<0.01%)	:arrow_up:
win_trunk_pkg	5.20% <100.00%> (-0.01%)	:arrow_down:
win_trunk_project	67.78% <100.00%> (+<0.01%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...com.unity.inputsystem/InputSystem/IInputRuntime.cs	80.00% <ø> (ø)
.../com.unity.inputsystem/InputSystem/InputManager.cs	88.70% <100.00%> (ø)
...s/com.unity.inputsystem/InputSystem/InputSystem.cs	82.96% <ø> (ø)
...nity.inputsystem/InputSystem/NativeInputRuntime.cs	45.12% <ø> (-0.05%)	:arrow_down:

... and 3 files with indirect coverage changes

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ekcoh]

@Pauliusd01 The refactored code parts are hit in the following cases:

• when starting/initializing with the incorrect active input backend setting
• when pausing a game in the editor

So a Quick Look for regressions in that area is what could be manually tested