CHANGE: Isxb 543 Removed aliased values in Gamepad enum.

[adrian-koretski-unity3d]

Description

Fixing confusing menu when selecting face buttons due to aliased enum values.

Changes made

Removed aliased enum values.

Testing

Manual testing.

Risk

None.

Checklist

Before review:

• [ ] Changelog entry added.
  • Explains the change in Changed, Fixed, Added sections.
  • For API change contains an example snippet and/or migration example.
  • JIRA ticket linked, example (case %<ID>%). If it is a private issue, just add the case ID without a link.
  • Jira port for the next release set as "Resolved".
• [ ] Tests added/changed, if applicable.
  • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
  • Performance tests.
  • Integration tests.
• [ ] Docs for new/changed API's.
  • Xmldoc cross references are set correctly.
  • Added explanation how the API works.
  • Usage code examples added.
  • The manual is updated, if needed.

During merge:

• [ ] Commit message for squash-merge is prefixed with one of the list:
  • NEW: ___.
  • FIX: ___.
  • DOCS: ___.
  • CHANGE: ___.
  • RELEASE: 1.1.0-preview.3.

After merge:

• [ ] Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

[unity-cla-assistant]

All committers have signed the CLA.

[ekcoh]

I would recommend considering a fix based off this one but with inlined/combined options for aliased entries? https://github.com/Unity-Technologies/InputSystem/pull/1862

[ekcoh]

Seems like @Billreyn was also considering that unless opinion has shifted, see https://github.com/Unity-Technologies/InputSystem/pull/1862#issuecomment-1971097297

[adrian-koretski-unity3d]

Seems like @Billreyn was also considering that unless opinion has shifted, see #1862 (comment)

I believe so. Based on our conversation, we want to display only North/South/East/West

[ekcoh]

Seems like @Billreyn was also considering that unless opinion has shifted, see #1862 (comment)

I believe so. Based on our conversation, we want to display only North/South/East/West

Exactly, with emphasis on "display", hence it should be property drawer only changes as I see it.

[Pauliusd01]

Will check this today or tomorrow morning at the latest

[adrian-koretski-unity3d]

Entering play mode with one of these new values selected breaks inspector and throws errors. Also, the enum value does not match the one in the inspector (See debug log in screenshot, whether that's expected I dunno)

The nullref issue should be fixed now. The value being displayed will be one of the aliased enums for that value so this is to be expected.

[Pauliusd01]

@adrian-koretski-unity3d I approved too hastily, the link has to be to a public issue tracker not our internal jira lol