InputSystem icon indicating copy to clipboard operation
InputSystem copied to clipboard

FIX: ISXB-687 Added guard clause to RemovePointerAtIndex in InputSy…

Open adrian-koretski-unity3d opened this issue 1 year ago • 1 comments

Description

When we disable a behaviour, the touch pointer no longer gets removed twice.

Changes made

Added code to prevent the first removal of the touch pointer (since we want to defer it to the following frame).

Testing

Manual testing

Risk

Low risk

Checklist

Before review:

  • [x] Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %<ID>%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • [ ] Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • [ ] Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • [ ] Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • [ ] Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

adrian-koretski-unity3d avatar Aug 13 '24 17:08 adrian-koretski-unity3d

CLA assistant check
All committers have signed the CLA.

unity-cla-assistant avatar Aug 13 '24 17:08 unity-cla-assistant

@adrian-koretski-unity3d Seems like it needs resolved conflict and CI rerun to get into green state before QA pass

ekcoh avatar Sep 05 '24 09:09 ekcoh

Will check this today

Pauliusd01 avatar Sep 30 '24 10:09 Pauliusd01