v4-core
v4-core copied to clipboard
Uniswap
Rename liquidityDelta in IPoolManager.ModifyPositionParams
Component
General design optimization (improving efficiency, cleanliness, or developer experience)
Describe the suggested feature and problem it solves.
I think the term "delta" should be conventionally used to describe credits or debits in token0 or token1 owed to or from the pool manager.
not sure of a better name tho... just liquidity?
Describe the desired implementation.
No response
Describe alternatives.
No response
Additional context.
No response
![linear[bot] avatar](https://avatars.githubusercontent.com/in/20150?v=4 "Published by a pub.dev verified publisher"){kind=small}
liquidityDelta is a fine name for the liquidity delta. Delta is a good term for any signed integer exclusively used for addition.
I like Delta given it refers to the change in liquidity for the position being modified.
I think that I had wanted to change callerDelta -> liquidityDelta in the return variables to match swap's swapDelta which means I dont want it to be overloaded with the params