uniswapx-parameterization-api icon indicating copy to clipboard operation
uniswapx-parameterization-api copied to clipboard

fix: correct clock skew on AWS global config

Open zhongeric opened this issue 1 year ago • 1 comments

Per the docs, correctClockSkew is automatically applied in aws cdk v3 in later: https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/migrating/notable-changes/

I think we are on V2 so we have to manually set this?

zhongeric avatar Aug 19 '24 14:08 zhongeric

We are using v3 sdk for s3:

import { GetObjectCommand, S3Client } from '@aws-sdk/client-s3';

@aws-sdk/<individual-component> is v3, import <...> from 'aws-sdk'; is v2

I think the only thing that's using v2 still is cw-log-firehose-processor, which is a lambda that transforms logs to firehose event format

ConjunctiveNormalForm avatar Aug 19 '24 14:08 ConjunctiveNormalForm