interface icon indicating copy to clipboard operation
interface copied to clipboard

fix: display chart when tickCurrent is zero

Open malijss opened this issue 2 years ago • 3 comments
trafficstars

Description

Updated the getActiveTick condition to recognize 0 as an acceptable tickAmount. This state can occur frequently when stable pools have a currentTick of zero.

Screen capture

Before

Screenshot from 2023-10-26 12-51-45

After

Screenshot from 2023-10-26 12-51-22

malijss avatar Oct 26 '23 09:10 malijss

@maliabr is attempting to deploy a commit to the Uniswap Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 26 '23 09:10 vercel[bot]

Codecov Report

Merging #7507 (e8b3db4) into main (6798bf3) will decrease coverage by 0.11%. Report is 57 commits behind head on main. The diff coverage is 0.00%.

Flag Coverage Δ
cloud-tests ?
unit-tests 43.12% <0.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Nov 15 '23 21:11 codecov[bot]

!= null is a good way for us to standardize on as a check if something is anything except null/undefined (but wont remove 0, empty string etc).

natew avatar Nov 28 '23 20:11 natew